Add API support for lists containing lists #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion, flattening and to/from RDF conversion. Also adds tests. For w3c/json-ld-syntax#36.
|
Changes to algorithms were straight-forward enough that I'm not sure why we ended up pushing it out of 1.0. |
This was referenced Aug 3, 2018
simonstey
reviewed
Aug 8, 2018
tests/README.md
Outdated
|
|
||
| * _remote-doc_ tests will likely not return expected HTTP headers, so the _options_ should be used to determine what headers are associated with the input document. | ||
| * Some algorithms, particularly _fromRdf_, may not preserve the order of statements listed in the input document, and provision should be taken for performing unordered array comparison, for arrays other than values of `@list`. (This may be difficult for compacted results, where array value ordering is dependent on the associated term definition). | ||
| * Some implementations may chose an alternative Blank Node Label algorithm, the comparison between documents containing blank node labels should take this into consideration. (One way to do this may be to reduce both results and _expected_ to datsets to extract a bijection mapping blank node labels between the two datasets as described in [RDF Dataset Isomorphism](https://www.w3.org/TR/rdf11-concepts/#dfn-dataset-isomorphism)). |
There was a problem hiding this comment.
-
s/may chose/may choose/
-
reduce both results and expected to datsets to extract a bijection mapping blank node labels between the two datasets
- "reduce both results and expected [results] to datasets to extract a
bijection mapping blank node labelsbijective mapping of blank node labels between the two datasets
- "reduce both results and expected [results] to datasets to extract a
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects expansion, compaction, flattening and to/from RDF conversion. Also adds tests.
For w3c/json-ld-syntax#36.
Preview | Diff