Skip to content

Fix error codes in tests being emitted as IRIs #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

rubensworks
Copy link
Member

Currently, the expected error codes in NegativeEvaluationTests are defined using the expect context term.
However, this term is defined with "@type": "@id", which causes the error codes to become IRIs, which is incorrect, as the spec describes them to be plain strings.

This PR adds a new expectErrorCode context entry, which expands to the same predicate as expect, but as a plain string. All NegativeEvaluationTests have been updated to make use of expectErrorCode instead of expect.

@gkellogg gkellogg self-requested a review October 22, 2019 15:00
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but we’ll need to update the README and template.md accordingly, and perhaps tweak the test vocabulary definition. Also, please use the rake task to regenerate the HTML versions of the test manifests.

@rubensworks
Copy link
Member Author

@gkellogg I've applied the changes you requested.

I did not change README.md, as it did not have any explicit mentions to expect, and instead refers to the vocab, where the distinction between expect and expectErrorCode is mentioned. (If you think this would be beneficial, I can add this into README.md as well)

@gkellogg gkellogg dismissed their stale review October 23, 2019 16:33

I'm satisfied.

@gkellogg
Copy link
Member

Thanks, Ruben. This is great. If running the tests is unclear, we'll get feedback.

Can you do the same for the framing tests?

@gkellogg gkellogg merged commit deb4f29 into w3c:master Oct 23, 2019
@gkellogg
Copy link
Member

I'll take care of the framing tests, as you don't work with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants