-
Notifications
You must be signed in to change notification settings - Fork 35
Update to make terms that have the form of a keyword errors. #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<a data-link-for="JsonLdErrorCode">keyword redefinition</a> | ||
error has been detected and processing is aborted. | ||
If <var>term</var> has the form of a keyword | ||
<var>term</var> MUST NOT be a <a>keyword</a>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually "MUST NOT have the form of a keyword" would be enough,
since all actual keywords also have the form of a keyword.
But it might be better to be explicit about the fact that we reject both actual keywords and would-be keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my thinking. An implementation can always choose to do this optimization.
Co-Authored-By: Pierre-Antoine Champin <[email protected]>
This issue was discussed in a meeting.
View the transcriptKeyword pattern should error when used as a termRob Sanderson: w3c/json-ld-syntax#297 Gregg Kellogg: while discussing syntax#296, I pointed out why we chose to have a number in @version; … ignoring keywords-like terms in the term definitions may cause the same problem in the future, … so I proposed to reject them instead. … If @version didn’t exist, 1.0 and 1.1 processors would generate different results by ignoring things.… Publishers can prevent that by using a specific version. … We are creating a pattern for future versions. … So I agree we should close this issue as wontfix. Dave Longley: do we throw an error if @version is not 1.1?Gregg Kellogg: yes … A future version would presumably allow 1.1 and something else (1.1, 2.0). Proposed resolution: Close #297 wontfix, change is too extensive, and @version deals with most of the problem as is (Rob Sanderson)Ivan Herman: +1 Rob Sanderson: +1 Dave Longley: re the problem raised in issue#296, internal representations might not evaluate exactly to 1.1 . … What advice do we want to give to implementors? Gregg Kellogg: I don’t think that this problem would happen in practice. Pierre-Antoine Champin: 1.1 is not represented exactly in float representation, but I agree that the problem is very unlikely to happen Benjamin Young: version numbers are not really numbers. … I don’t think that future versions should use 1.* . Proposed resolution: Close #297 wontfix, change is too extensive, and @version deals with most of the problem as is (Rob Sanderson)Rob Sanderson: +1 Gregg Kellogg: +1 Gregg Kellogg: we should not put restrictions on future WG. Pierre-Antoine Champin: +1 Benjamin Young: +1 Dave Longley: +1 Ivan Herman: +1 Resolution #2: Close #297 wontfix, change is too extensive, and @version deals with most of the problem as isDavid I. Lehn: +1 |
If we decide we want to make keyword-like terms an error, this PR does that for the API.
For w3c/json-ld-syntax#297.
Preview | Diff