-
Notifications
You must be signed in to change notification settings - Fork 20
Lazy-Eval processingMode. #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a3b972
to
59730d0
Compare
59730d0
to
9965654
Compare
pchampin
approved these changes
Oct 17, 2019
dlongley
approved these changes
Oct 17, 2019
index.html
Outdated
Once set, it is an error to attempt to change to a different processing mode, | ||
and processors MUST generate, | ||
a <a data-cite="JSON-LD11-API#dom-jsonlderrorcode-processing-mode-conflict">processing mode conflict</a> | ||
error and abort further processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar "make sure we can upgrade but not downgrade" concern here.
This was referenced Oct 18, 2019
This issue was discussed in a meeting.
View the transcriptLazy evaluation of 1.1 processing modeRob Sanderson: w3c/json-ld-api#161 Gregg Kellogg: Also w3c/json-ld-syntax#284 Gregg Kellogg: #76 Gregg Kellogg: w3c/json-ld-api#170 Rob Sanderson: It would be easier for version migration compliance to handle @version keyword lazily, and let processors detect them based on the features that are being used.Gregg Kellogg: When we discussed it, the idea was that we would do feature detection, and move up to 1.1 when we saw that. … If you are explicitly in 1.0 mode, then you don’t run any 1.1 features. If one such feature would be 1.1, then a 1.0 processor would terminate. … This would happen in any case on old processors if they see unknown (new) features. … The PRs describe this slight change and the necessary steps. Dave Longley: +1 to gregg’s description of how lazy eval works Rob Sanderson: There was a question about the tests to see if there were any issues. Gregg Kellogg: There weren’t any exceptions. I just added a couple of tests. … I’ve updated many tests that used to the processing mode explicitly, and things seem to work correctly. Dave Longley: As we will probably will have a JSON-LD 1.2 at some point, we don’t want to lock down the version in the algorithm. Ivan Herman: +1 dlongley Gregg Kellogg: I agree. Rob Sanderson: +1 as well Rob Sanderson: Is this written like that in the PRs? Dave Longley: +1 to remove those clauses Gregg Kellogg: Yes, the PRs make it so that processing mode can be “unset”, which allows the silent upgrade. Dave Longley: +1 to merge the PRs with the above changes Ivan Herman: +1 for me, too Gregg Kellogg: The conformance section describes changes to proc mode as well, besides the algorithmic changes. Proposed resolution: Accept changes after changing clause for explicit 1.1 for API #161, lazy evaluation of processing mode (Rob Sanderson) Rob Sanderson: +1 Gregg Kellogg: +1 Ruben Taelman: +1 Dave Longley: +1 David I. Lehn: +1 Pierre-Antoine Champin: +1 Resolution #3: Accept changes after changing clause for explicit 1.1 for API #161, lazy evaluation of processing mode Gregg Kellogg: Another useful thing would be a doc/post about the process to update to 1.1. Ivan Herman: We have to clarify that this is not just lazy evaluation, but it is better than just that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major implication is that a top-level
@graph
is only output for a single node if processingMode is set explicitly tojson-ld-1.0
, previously it would be output unless processingMode is set explicitly tojson-ld-1.1
.For w3c/json-ld-api#161.
Preview | Diff