Skip to content

clarifications as suggested in #170 and w3c/json-ld-wg#85 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2019

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Jun 13, 2019

as per my action


Preview | Diff

@iherman
Copy link
Member

iherman commented Jun 13, 2019

I have just a minor comment: the text includes the text:

However, all URIs starting with http://www.w3.org/ns/json-ld are reserved for future use by JSON-LD specifications.

A "Note" is automatically non normative. I wonder whether it would not be better to move this text into the 'normative' text, right after the list of json-ld URI-s (and probably without the word 'However').

Otherwise it looks o.k. to me.

@BigBlueHat
Copy link
Member

Also, @pchampin I think you want us added as "reviewers" not "assignee's" (you would be the assignee for this one. 😃

@pchampin
Copy link
Contributor Author

@BigBlueHat indeed I did. Sorry about that...

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@BigBlueHat
Copy link
Member

@BigBlueHat indeed I did. Sorry about that...

No worries! 😄

@pchampin pchampin merged commit 16c60eb into master Jun 13, 2019
@gkellogg gkellogg deleted the profile_extensibility branch September 23, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants