-
Notifications
You must be signed in to change notification settings - Fork 23
Add playground links to most examples #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1754f26
to
cd3c25d
Compare
cd3c25d
to
37407f1
Compare
I wonder what the problem is, there may be some tricky HTML issues...
Any idea? (I am, of course, all in favor of adding those links to the examples!) |
Forget my previous remark about rawgit. It works if one uses the URL of the index.html file (not with the repo as a whole): https://rawgit.com/w3c/json-ld-syntax/playground-links/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I find the playground logo in the tab a bit disturbing and unclear. I would prefer to spell it out
- in some cases (e.g. Example 14) the link leads to an error message because the JSON-LD is, well, invalid (it contains a
...
) :-(
Yes, I think I know the source of the invalid JSON-LD. Would you see a similarly styled button for this instead, or just a link such as “open in playground”? |
@gkellogg I would just use text as for all the other options |
@iherman Changed style to use buttons. |
Thanks! As far as I am concerned, we can merge this... |
It is a bit odd to have tabs you can flip between and another "tab" that is actually an action to open a another site. Fine for now unless anyone has a better UI idea. |
Agreed with @davidlehn about needing consistency among the experience of the tabs. Also, the styles have some issues in the latest Firefox, fwiw. |
A UI designer I am not. I would appreciate anyone’s help in styling. As for the separate button for the playground link, this is entirely manipulated in JavaScript, so something else would be easy to propagate. Personally, I found the previous icon taken from json-ld.org reasonable, is it is representative of where the link will take you. When saved, there is an aria label that indicates it’s purpose. |
I missed the logo preview, but that does sound nice. Also, I sadly can't take a look at the UI stuff until next week (currently tied up with event running), but I'd be happy to then. UX was most of what I did until I got into standards. 😄 🎨 |
@BigBlueHat It's never too late on GitHub! https://rawgit.com/w3c/json-ld-syntax/7abb999a4ae7dd1b8f88d0fedb7617e16e6091fa/index.html. |
5cb37ae
to
f82f597
Compare
@BigBlueHat said:
It doesn't resize content when programmatically updated, apparently. I updated to give a classname and style with I'm going to go ahead and merge this, along with the other repos; we can work on other styling issues later. |
Only does expansion, at least for now.
Fixes #48.