-
Notifications
You must be signed in to change notification settings - Fork 36
Should pointer events and compatibility mouse events have the same timestamp? #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe compatibility mouse events are the non-normative part of the spec. So in that sense we shouldn't even need to have the test for it. Having said that, there are some tests that just check the current common behaviors of the implementors without having the exact specification for it. Like the one you mentioned. |
I don't really see the value in ensuring that the timestamp is the exact same value, at least it doesn't seem like a good idea to me for an author to rely on this kind of data to make any kind of assumption. I might also be biased by the extra work required to make this work in WebKit :) So I would advocate that we remove the specific part of the test about equal timestamps. |
I don't mind removing that from the tests. @smaug---- WDYT? |
If we're in agreement, I have a PR to change the test at web-platform-tests/wpt#17041. |
I agree the spec doesn't require this, so relaxing the tests seems fine. That said, a couple years ago I believe we did get agreement that |
…se events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses #17016. (#17041)
…vents/pointerevent_suppress_compat_events_on_drag_mouse.html https://bugs.webkit.org/show_bug.cgi?id=197008 Patch by Antoine Quint <[email protected]> on 2019-05-28 Reviewed by Jon Lee. We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see w3c/pointerevents#284 and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and the TestExpectations. LayoutTests/imported/w3c: * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt: * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html: LayoutTests: * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@245820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
… events and compatibility mouse events have the same timestamp, a=testonly Automatic update from web-platform-tests Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041) -- wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4 wpt-pr: 17041
… events and compatibility mouse events have the same timestamp, a=testonly Automatic update from web-platform-tests Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041) -- wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4 wpt-pr: 17041
…se events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses #17016. (#17041)
… events and compatibility mouse events have the same timestamp, a=testonly Automatic update from web-platform-tests Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041) -- wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4 wpt-pr: 17041 UltraBlame original commit: 48ef3551127afc3366932e147ead62fe9aeb5a6a
… events and compatibility mouse events have the same timestamp, a=testonly Automatic update from web-platform-tests Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041) -- wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4 wpt-pr: 17041 UltraBlame original commit: 48ef3551127afc3366932e147ead62fe9aeb5a6a
… events and compatibility mouse events have the same timestamp, a=testonly Automatic update from web-platform-tests Remove the test that checks that pointer events and compatibility mouse events have the same timestamp. There is no requirement by the specification to do this as per the discussion in w3c/pointerevents#284. This addresses web-platform-tests/wpt#17016. (#17041) -- wp5At-commits: b89470bffd7c2fea14d7822fc18862cf5d8b57b4 wpt-pr: 17041 UltraBlame original commit: 48ef3551127afc3366932e147ead62fe9aeb5a6a
Uh oh!
There was an error while loading. Please reload this page.
I'm asking this because one of the WPT tests (pointerevent_suppress_compat_events_on_drag_mouse.html) expects it to be the case but I can't find anything in the spec to back that up. Either this should be made clear in the spec or that assertion should be removed. I've raised an issue on wpt about that at web-platform-tests/wpt#17016.
The text was updated successfully, but these errors were encountered: