Skip to content

Conversation

domel
Copy link
Contributor

@domel domel commented Aug 18, 2025


Preview | Diff

@domel domel requested a review from gkellogg August 18, 2025 17:20
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. I can't note everything through inline comments:

Table styling changed, and probably the class needs to be updated in the two Escape Sequences tables, as compared with w3c/rdf-turtle#107.

The Term Constuctors table for PNAME_NS and PNAME_LN should have the same IRI provisions as IRIREF.

The LANG_DIR constructor needs the statement about being well-formed.

The Diff view for w3c/rdf-turtle#107 shows where parallel changes are needed, at least those that are visible in the render.

@domel domel dismissed gkellogg’s stale review September 15, 2025 20:04

For known reasons, unlocking is not possible

@domel domel marked this pull request as ready for review September 15, 2025 20:04
@domel domel requested review from afs and niklasl September 15, 2025 20:04
@domel domel requested review from kasei and rubensworks September 28, 2025 15:55
@domel domel requested a review from kasei October 3, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants