-
Notifications
You must be signed in to change notification settings - Fork 117
Non-normative changes from Jeffrey Yasskin's review #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
A couple notes based on the questions in #1285 (comment) and later:
This was just about the word "valid" needing a definition in the context of proof types. If nobody's supposed to check their validity, just remove "valid". I think the work in #1338 is going to help with this: you'll be able to say a proof type with a specified securing algorithm that fits the interface you'll define in #1338.
Here I was suggesting that it'd be nice if the non-normative warnings like "The process of performing these checks might result in information leakage" could instead become normative requirements that prevent the leakage. That won't be possible for every warning, and to the extent that these only happen during Validation, you don't actually have normative language about it at all, so maybe no improvement is possible. I think you've captured everything else. Thanks! |
The issue was discussed in a meeting on 2024-02-14
View the transcript2.3. Non-normative changes from Jeffrey Yasskin's review (issue vc-data-model#1348)See github issue vc-data-model#1348. Brent Zundel: Non-normative changes from Jeffrey Yasskin's review #1348. currently assigned to manu. Manu Sporny: I will do this one. in theory all editorial changes. will take me a while since there are so many of them. |
The issue was discussed in a meeting on 2024-02-28
View the transcript3.10. Non-normative changes from Jeffrey Yasskin's review (issue vc-data-model#1348)See github issue vc-data-model#1348. Brent Zundel: Manu, do you need anything on this one? Manu Sporny: This one scares me ... it's not one issue, it's like 30 things that Jeffrey would like to have changed but they are all in theory editorial. This one will take the longer amount of time. Brent Zundel: It's good that we've wrapped around on the issue discussion. Hopefully we'll positively increase the pressure to get these done. Dave Longley: welcome! |
The issue was discussed in a meeting on 2024-03-06
View the transcript2.8. Non-normative changes from Jeffrey Yasskin's review (issue vc-data-model#1348)See github issue vc-data-model#1348. Joe Andrieu: understood. Brent Zundel: 1348. Manu Sporny: this ones mine. It'll take a few days, but I should be able to do it. |
The issue was discussed in a meeting on 2024-03-13
View the transcript4.4. Non-normative changes from Jeffrey Yasskin's review (issue vc-data-model#1348)See github issue vc-data-model#1348. Brent Zundel: will not be marked pending close. Jeff Y. review. manu: trying to address as many as possible. David Chadwick: section on trust model Jeff Y. wants quite a lot. I'm willing to work on but need more discussion. Break out into. Manu Sporny: can skip section 5.2, will provide commit for each checkmark. agree trust model changes require discussion. |
Concerning section 5.2, trust model, here is my input for discussion.
This can be done as a simple editorial PR. Happy to do that for the WG.
We can say that the VDR contains metadata about issuers, holders and verifiers and is trusted because of the method of its publication. This could be by a peer to peer protocol from a trusted publisher, or on a publicly accessible and well known web site, or on a blockchain etc. When entities publish meta data about themselves, this can be integrity protected e.g. by signing with the entity's private key.
We can say that in many cases the holder will have a pre-existing trust relationship with the issuer, and will trust all the information that it provides, for example, an employer providing an employment VC to an employee, or a bank providing a banking VC to a customer, or a government issuing a passport VC to a citizen. In other cases, where no pre-existing relationship exists, the holder would be advised to have some out of band means of determining if the issuer can be trusted to issue the VC that it provides.
We can say that how verifiers decide which issuers to trust is out of scope of the recommendation. However some issuers, e.g. well known organisations, may be implicitly trusted by many verifiers because of their reputation. Other issuers and verifiers may be members of a specific group and all group members trust each other. Other verifiers may trust a specific trust service provider whose responsibility is to vet issuers and list them in a trust list e.g. as specified in ETSI TS 119 612 [ref]. |
PR #1469 addresses the comments on section 5.2 |
The issue was discussed in a meeting on 2024-04-10
View the transcript2.2. Non-normative changes from Jeffrey Yasskin's review (issue vc-data-model#1348)See github issue vc-data-model#1348. Brent Zundel: 1348, non-normative changes from J Yaskin. Manu Sporny: i would love help on this, not sure how to distribute the task, other than people picking sections from the big long list. David Chadwick: the bit I've done is nearly agreed on now. the one thing I don't know how to do is to add a reference to an external document. Manu Sporny: at the top of the document, there's a section called Biblio or something like, that has a bunch of square brackets, that's where you add it.
David Chadwick: I couldn't find that section. Manu Sporny: ok, yeah, what dlongley said.
Brent Zundel: just to note for the minutes, PR 1469 is DavidC's PR that he's addressing.
Brent Zundel: and manu's PR for the rest is 1464. |
This issue tracks the NON-normative changes requested from @jyasskin's review (issue #1285) of the VC v2.0 specification:
1. Introduction
1.1 What is a Verifiable Credential?
1.3 Use Cases and Requirements
3.2 Credentials
4.1 Getting Started
4.2 Contexts
4.3 Identifiers
4.4 Types
5.1 Lifecycle Details
5.2 Trust Model
5.3.1 Semantic Interoperability
5.4 Integrity of Related Resources
5.5 Refreshing
5.11 Ecosystem Compatibility
6.3 Proof Formats
7. Privacy Considerations
7.3 Personally Identifiable Information
7.4 Identifier-Based Correlation
7.5 Signature-Based Correlation
7.6 Long-Lived Identifier-Based Correlation
7.8 Favor Abstract Claims
7.9 The Principle of Data Minimization
7.11 Validation
7.12 Storage Providers and Data Mining
7.14 Usage Patterns
8.3 Content Integrity Protection
relatedResource
feature.A.1 Credential Type
The text was updated successfully, but these errors were encountered: