Skip to content

Remove proof property from most examples #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
David-Chadwick opened this issue Aug 31, 2021 · 6 comments
Closed

Remove proof property from most examples #811

David-Chadwick opened this issue Aug 31, 2021 · 6 comments
Labels
editorial Purely editorial changes to the specification. pending close Close if no objection within 7 days

Comments

@David-Chadwick
Copy link
Contributor

Now that we have some proposed text to clarify the difference between a credential (presentation) and verifiable credential (presentation), I think it would be a good idea for most of the examples in sections 4 and 5 e.g. for type, issuer, issuanceDate etc. to remover the "proof": {...} property from the examples as:
i) it wrongly implies that all verifiable credentials will have the proof property, and
ii) it has nothing to do with the property being described.

The place to introduce the proof property "proof":{..} is in section 4.7 which deals specifically with proofs.

Footnote. When the recommendation was being drafted I for one originally thought that the proof property would always be present for every VC, and if the VC was JWT signed, then the proof property would say something about the JWT. We did discuss this at length, but eventually it was agreed not to have a proof property for JWT signed VCs. Thus I think the right thing to do now is to remove it from all the examples where it is not relevant.

@iherman
Copy link
Member

iherman commented Sep 9, 2021

The issue was discussed in a meeting on 2021-09-08

  • no resolutions were taken
View the transcript

4.2. Remove proof property from most examples (issue vc-data-model#811)

See github issue #811.

Brent Zundel: Next, issue 811

David Chadwick: Right, this is mine that I raised earlier in this meeting.
… If people agree, we can remove the "proof": ... except for the section that talks about proof.

Brent Zundel: The conversation earlier, nobody objected to that.
… So I would move on with the PR. I'll throw a label on it.
… Now we can look at the last one - also yours, David.
… v1.1 or v1.2

@brentzundel brentzundel added editorial Purely editorial changes to the specification. v2.0 and removed v1.1 (editorial) labels Oct 27, 2021
@David-Chadwick
Copy link
Contributor Author

The v1.1 PR has already been produced for this. it is #817

@kdenhartog kdenhartog linked a pull request Nov 3, 2021 that will close this issue
@kdenhartog
Copy link
Member

The reason for relabeling this during TPAC was that there's disagreement around how this removal should be represented. Presuming we're able to update the examples to have tabbing included then adding this change wasn't an issue. However, there was some concern around completely removing proof properties from the examples.

I think the solution here is that we hold off on merging #817 and instead go forward with the multi-tabbed approach where credential and verifiable credential objects can be represented with the various descriptive proof objects included.

@iherman
Copy link
Member

iherman commented Nov 10, 2021

The issue was discussed in a meeting on 2021-10-27

  • no resolutions were taken
View the transcript

2.7. Remove proof property from most examples (issue vc-data-model#811)

See github issue vc-data-model#811.

Manu Sporny: seems a lot of work, more than 1.1 timeline allows.

Kyle Den Hartog: +1 from me, manu speaks my mind.

Brent Zundel: for the record, any issue labeled as editorial can be PRd at any time, regardless of version timelines! feel free to do this, if you're listening/reading this and have strong feelings.

@Sakurann Sakurann added the pending close Close if no objection within 7 days label Jul 26, 2022
@Sakurann
Copy link
Contributor

vc-data-model v1.1 already has examples of credential and verifiable credential separately, so we can close this issue.

@brentzundel brentzundel removed the v2.0 label Jul 29, 2022
@brentzundel
Copy link
Member

No comments since marked pending close, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Purely editorial changes to the specification. pending close Close if no objection within 7 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants