Skip to content

Fix the JWT encoding in the examples #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msporny opened this issue Nov 17, 2021 · 3 comments
Closed

Fix the JWT encoding in the examples #838

msporny opened this issue Nov 17, 2021 · 3 comments
Assignees

Comments

@msporny
Copy link
Member

msporny commented Nov 17, 2021

The JWT encoding in the examples in PRs #834 #835 are currently incorrect. Fix the JWT encoding to align with the examples.

@msporny msporny self-assigned this Nov 17, 2021
@msporny
Copy link
Member Author

msporny commented Dec 8, 2021

This is mostly done. @David-Chadwick requested that we include a comment on the duplication of some of the fields in the JWT. This issue can't be closed until that is fixed. I plan to fix that at some point in the near future.

@iherman
Copy link
Member

iherman commented Dec 8, 2021

The issue was discussed in a meeting on 2021-12-08

  • no resolutions were taken
View the transcript

4.2. Fix the JWT encoding in the examples (issue vc-data-model#838)

See github issue vc-data-model#838.

Brent Zundel: Manu raised this -- can you give an update?.

Manu Sporny: I did this, but I still haven't applied David Chadwick's request for a comment about using one JWT mechanism over the other. I'll put an update in here, it's not done yet, it will be when I implement David's request..

@msporny
Copy link
Member Author

msporny commented Jan 15, 2022

@David-Chadwick requested that we include a comment on the duplication of some of the fields in the JWT.

This was done in ab18790 as a purely editorial point release upgrade to respec-vc v1.0.1, which includes the statement that @David-Chadwick asked for. This issue is resolved.

@msporny msporny closed this as completed Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants