Skip to content

Add 'render' hint property to v2 context #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dmitrizagidulin
Copy link
Contributor

This standalone PR adds the render hint property to the VC 2.0 @context. (Note: this separate from PR #1035).

The render hint allows for linking to, or embedding, issuer display preferences / hints in a flexible manner (see the Rendering Verifiable Credentials paper from RWOT 11 for more info and examples).

The intention is to add examples of render usage to the VC Spec directory.

@brentzundel
Copy link
Member

I assume this PR depends on agreement around #1035. I'm not understanding why we would add render to the V2 @context otherwise.
Is that correct?

@dmitrizagidulin
Copy link
Contributor Author

I assume this PR depends on agreement around #1035. I'm not understanding why we would add render to the V2 @context otherwise. Is that correct?

This is an alternative, lighter-weight proposal to PR #1035 that reserves the term so that extension specifications can use it.

@brentzundel
Copy link
Member

without spec text indicating that the term is being reserved, I don't think adding render to the @context file would be appropriate.

Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe we should add the render property to the core v2 context.

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @brentzundel that it's unnecessary to add this property.

@Aisp-GitHub
Copy link

Sorry it was a mistaken operation about approving the change on adding render property.

@dmitrizagidulin
Copy link
Contributor Author

No consensus was able to be reached, closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants