-
Notifications
You must be signed in to change notification settings - Fork 117
Modernize examples in specification #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A comment on the "Getting Started" example, (Example 3 in §4.1). An attentive reader's reaction may be that the example is incorrect JSON-LD, because there is no definition for, e.g., |
Looking at the examples, there is still room for confusion for the user. The term definitions come from (at least) four different places:
I know from my own experience that all this is extremely confusing, and makes it very difficult to understand the spec. One way of handling this may be:
I am fine if the comment is "Ivan, let us do this in a different PR". But I consider it imperative to do it at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look OK, as far as they go. I share @iherman's concerns, and think there should be an issue opened for them if they are not addressed in this PR, so we don't forget to address them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These diagrams don't match the consensus regarding "proof" and "credential".
We had some really long threads about how "proof" is part of both "credential" and "verifiable credential"
These diagrams show proof as separate graph object.
This does correspond to what the JSON-LD context does when it is applied, but the context is not normative, so the diagrams are not reflective of normative requirements... and they seem to be contradicting consensus on "anything can have a proof".
These diagrams might be better in vc-data-integrity.
Technically "proof" is defined inside of "VerifiableCredential" and "VerifiablePresentation":
https://github.com/w3c/vc-data-model/blob/main/contexts/credentials/v2#L51
I am requesting the following changes:
- Use "VerifiableCredential" not "Credential".
- Add examples for JWT (or file an issue and link to tools so I can provide equivalent diagrams).
Related issue regarding aligning informative examples, with normative requirements... #1103 (comment) |
Related to the "Credential" vs "VerifiableCredential" part... #1126 (comment) |
Related issue: #881 Discussed on the call today. |
@OR13 wrote:
This was done in 6156f48 and 96920dd.
The Editors of the VC-JWT specification can provide those. I've raised issue#1135 for them to process. I believe this addresses both of your change requests @OR13, please re-review. |
See this PR which attempts to update the examples, and the related tooling currently being deployed... w3c/respec-vc#8 I think it would be better to simply switch to mermaid at this point... but I can do that in a subsequent PR. |
I agree with @iherman 's comments about the proof values, we expect to see It would be good to make the diagrams consistent, with the actual nquads. |
+1 to Ivan's suggestion for future attention, and the resolution to the naming issues Manu has responded to from Orie. If I were an approver I'd agree, too! |
Editorial, multiple reviews, changes requested and made, no objections, merging. |
This PR modernizes the examples in the specification by:
RsaSignature2018
examples to useDataIntegrityProof
.@lang
/@value
examples and using simpler text instead.This PR addresses #967 and #1121.
Preview | Diff