-
Notifications
You must be signed in to change notification settings - Fork 117
Added the new vocabulary file for undefined terms #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweak citation reference
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, some minor nits before we merge.
Co-authored-by: Manu Sporny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial fixups
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a mistake. We would be better off with @vocab
in the main context so there are no undefined terms.
The issue was discussed in a meeting on 2024-07-31
View the transcript1.3. Publish undefined-terms context URI (issue vc-data-model#1534)See github issue vc-data-model#1534. See github pull request vc-data-model#1536. Manu Sporny: for next item Ivan has raised a PR, once those three are done, no more issues on VCDM. |
@msporny can this PR be merged (and the .htaccess file updated)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still prefer @vocab being in the base context but I understand that that ship has sailed.
The issue was discussed in a meeting on 2024-08-07
View the transcript1.1. Added the new vocabulary file for undefined terms (pr vc-data-model#1536)See github pull request vc-data-model#1536. Brent Zundel: We have a PR we should look at. Ivan Herman: Just to say what you said here a little differently. There were a number of comments, so they have all been incorporated, so as far as I know, no more open comments. Brent Zundel: Thanks for that summary, Ivan. Ivan Herman: That is correct. Brent Zundel: Ted and Mike Jones, your reviews are still showing requests for changes, Ted your changes have been merged, Mike if you'd like to jump on the queue you can do so. Michael Jones: Alright, I still think it's a mistake but I think the ship has sailed and I'll approve it. Brent Zundel: Thank you Mike, I appreciate that.
Brent Zundel: There are two remaining issues on the VCDM. |
Merging per https://www.w3.org/2017/vc/WG/Meetings/Minutes/2024-08-07-vcwg#section1-1. The |
* main: Added the new vocabulary file for undefined terms (#1536) Add explanation of securing mechanism examples. Remove mention of ZKP schemas since we have no examples to point to. Reformat status spec requirements in Status section.
This is to settle issue #1534. Some remarks, though:
issuer-dependent.html
file, namely the VCDM reference has been updated. However, the question is whether this file is still necessary or not or, under the circumstances, should be removed./ns/credentias/.htaccess
file. Because the file is not on github, it cannot be managed directly by the PR, so I copy this verbatim below. Please, give your comments here, and I will make the changes separately.https://w3c.github.io/vc-data-model/contexts/credentials/undefined-term/v2
is a 404; I presume you have some magic with gh-pages going on which must be adapted for the new file. I am not sure what to do with this, I leave this in your able hands.Here is the
.htaccess
file itself: