Skip to content

Remove delegation #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 19, 2018
Merged

Remove delegation #283

merged 5 commits into from
Dec 19, 2018

Conversation

David-Chadwick
Copy link
Contributor

@David-Chadwick David-Chadwick commented Nov 16, 2018

second verifiable credential is likely to be application specific, and therefore
this specification does not standardise the contents of this second verifiable
credential. Nevertheless a non-normative example is given in Appendix A.2
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this paragraph.

index.html Outdated
The Subject Only Terms of Use states that a verifiable credential MUST only be
presented to a verifier by the subject. If a verifier is presented with a
verifiable credential containing the Subject Only Terms of Use, by anyone other
than the subject, it MUST refuse to accept it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With selective disclosure, there is no way to ensure that a verifier ever sees the Subject Only Terms of Use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the question here about this issue: #282 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post ZKP discussion: The selective disclosure schemes being implemented do indicate that a ToU is present in a credential definition, allowing for a verifier to request it (and thereby require it). The presenter can also prove if their particular credential happens to not possess a ToU should it be requested but not present.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. So I will update the PR to remove conflicts with the latest version of the spec

@msporny
Copy link
Member

msporny commented Dec 4, 2018

Merge conflicts are preventing the merge of this PR.

@David-Chadwick
Copy link
Contributor Author

I believe I have now resolved the conflicts, and I have also replaced the subjectOnly ToU with subjecOnly property.

@msporny. I already posses two physical plastic cards that are marked subjectOnly by the issuer. So I am quite sure that this property will be a common use case for VCs.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A file called index.text has been added to this PR. Please remove it so I can pull the PR in. All the other changes seem good to me.

@msporny I dont know how this happended or what it contains. I also dont know how to remove it. Can you advise me please

@msporny
Copy link
Member

msporny commented Dec 18, 2018

@msporny. I already posses two physical plastic cards that are marked subjectOnly by the issuer. So I am quite sure that this property will be a common use case for VCs.

It's not the use case that I'm concerned about. It's the data modeling aspect of it, which I haven't been able to think about deeply. At present, almost all VCs our company is issuing are "subjectOnly" credentials, which are implicit and which the verifier determines whether or not to allow anyone except for the subject to use them... the rules are often complex and we are concerned about issuers placing "subjectOnly" on every credential and hobbling the ecosytem by doing so. Like, for example, due to regulatory pressures, prescription issuing software may mark those VCs as "subjectOnly" when quite often people pick up prescriptions for other people. Marking those things as "subjectOnly" may force implementations to break conformance to make complex determinations... subjectOnly feels like a hammer for an ill-defined problem.

@David-Chadwick
Copy link
Contributor Author

@msporny. I think you are introducing red herrings in your discussion above.
First you do not hobble any system with our conformance clauses because we have already agreed that any verifier can accept anything at its own liability. So in this case the verifier would switch off any software checking that might be in the validation code (and be non-conformant to whichever protocol spec it was using). So breaking conformance as you suggest is not a data model issue, it is a usage and protocol issue which is out of the scope of our standard.

In one of my plastic cards, the local council is the issuer of my free bus pass, and it has EXPLICITLY stipulated Subject Only on it, to all the verifiers (buses) in the country. i.e. only I am entitled to free travel on buses with this VC. So
a) it does not matter who the verifier is
b) it does not matter what the usage is
b) it is not implicit it is explicit
A standard way of indicating this in the data model will be a common requirement.

@David-Chadwick
Copy link
Contributor Author

@msporny I don't know how the index.text file got there and I don't know how to delete it. Could you help please

@msporny
Copy link
Member

msporny commented Dec 19, 2018

A standard way of indicating this in the data model will be a common requirement.

Yes, agreed. I don't think the current way it's being expressed in the data model is the right way to do it... but don't have an alternate suggestion at this point (I will in time, but haven't been able to think about it deeply). In other words, not suggesting how to do it is better than suggesting the wrong way to do it.

I think the right way to do it is probably by putting it in termsOfUse that the issuer provides.

@msporny msporny merged commit 0ed0919 into w3c:gh-pages Dec 19, 2018
@msporny
Copy link
Member

msporny commented Dec 19, 2018

@msporny I don't know how the index.text file got there and I don't know how to delete it. Could you help please

Fixed.

@David-Chadwick
Copy link
Contributor Author

@msporny Thanks for fixing the index.text file problem.
However, your argument is a non sequitur. "I have not thought about it deeply" but "the current way ... is the wrong way" ?*?
Have a Happy Christmas and maybe when you are digesting your turkey dinner you might come up with a better way :-)
In which case I will only be too happy to support it in 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants