Skip to content

Clarify why processing @context is useful for JSON-based processors. #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2019

Conversation

msporny
Copy link
Member

@msporny msporny commented Apr 14, 2019

Related to issue #491.


Preview | Diff

chaals added a commit that referenced this pull request Apr 14, 2019
An editorial alternative to proposal #546, related to issue #491
Copy link
Contributor

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text does what is required and I would be happy for it to be merged.

I raised #548 as an alternative for the same thing because a line-by-line commentary turned out to be a difficult way to express what I thought might be improved. Feel free to merge either one and close the other.

index.html Outdated
<code>@context</code> mechanism. This is because the exact terms that a
producer and consumer of the data model described by this specification,
as well as any extensions used, are explicitly stated through the use and
processing of the <code>@context</code> property. In other words, the context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble parsing the sentence starting with This is because... ... I think a word was forgotten or something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ad5c9bc.

@msporny
Copy link
Member Author

msporny commented Apr 15, 2019

I raised #548 as an alternative for the same thing because a line-by-line commentary turned out to be a difficult way to express what I thought might be improved. Feel free to merge either one and close the other.

I like some of the language in your PR better than the language in this one. I'll try to merge PR #548 with this one where it makes sense to do so.

Copy link
Member

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once @dlongley's comments are addressed, I approve this PR.

Copy link
Contributor

@ken-ebert ken-ebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve (with dlongley's suggested fixes.)

@msporny msporny force-pushed the msporny-issue-491 branch from be47a1f to ad5c9bc Compare April 24, 2019 01:55
@msporny
Copy link
Member Author

msporny commented Apr 24, 2019

Applied all changes requested by @dlongley. Merged PR #548 from @chaals into this PR. Multiple positive independent reviews. Editorial. Merging.

@msporny msporny merged commit 2dde7d4 into gh-pages Apr 24, 2019
@msporny msporny deleted the msporny-issue-491 branch April 24, 2019 04:08
@David-Chadwick
Copy link
Contributor

I have one question about this text which is, how does a JSON processor find the human readable document that is referred to? The text only says that the machine-readable description should exist at the URL in the @context. Wouldn't it be better to say that the human readable version should also be at the same URL, perhaps as comments in the JSON-LD.

This is the text I am questioning:

A human-readable document describing the expected order of values for the
@context property is expected to be published by any
implementer seeking interoperability. A machine-readable description
(i.e., a normal JSON-LD Context document) is expected to be published
at the URL specified in the @context property by
JSON-LD implementers seeking interoperability.

@msporny msporny mentioned this pull request Apr 26, 2019
@msporny
Copy link
Member Author

msporny commented Apr 30, 2019

@David-Chadwick can you please open a new issue on the item you placed above.

@David-Chadwick
Copy link
Contributor

Done. You can close this PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants