Skip to content

"final holder" may not be "final" #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

"final holder" may not be "final" #577

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0addd
"final holder" may not be "final"
TallTed Apr 24, 2019
b1f6df9
Update index.html
TallTed Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,37 +1816,39 @@ <h3>Lifecycle Details</h3>

<ol>
<li>
The <a>verifier</a> defines its policies for accepting
A <a>verifier</a> defines its own policies for accepting
<a>verifiable credentials</a> from <a>holders</a> for its supported actions.
</li>
<li>
The <a>issuer</a> issues a <a>verifiable credential</a> to the <a>holder</a>.
An <a>issuer</a> issues one or more <a>verifiable credentials</a> to
a <a>holder</a>.
</li>
<li>
The <a>holder</a> might pass on its <a>verifiable credentials</a> to another
<a>holder</a>.
A <a>holder</a> might pass on one or more of its <a>verifiable credentials</a>
to another <a>holder</a>.
</li>
<li>
The final <a>holder</a> presents its <a>verifiable credentials</a> to the
<a>verifier</a> in a <a>verifiable presentation</a>, requesting a supported
A <a>holder</a> presents one or more of its <a>verifiable credential(s)</a>
to a <a>verifier</a> in a <a>verifiable presentation</a>, requesting a supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to say optionally since VPs are optional not mandatory. Therefore change to

A holder presents one or more of its verifiable credential(s)
to a verifier, optionally in a verifiable presentation, requesting a supported

action.
</li>
<li>
The <a>verifier</a> <a>verifies</a> the authenticity of the
<a>verifiable presentation</a> and <a>verifiable credentials</a>.
A <a>verifier</a> <a>verifies</a> the authenticity of a <a>verifiable presentation</a>
and the <a>verifiable credential(s)</a> contained therein.
</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous step had a holder passing to a verifier. So this step should be talking about the same holder and the same verifier. It makes no sense to talk about any holder or any verifier since they may not have communicated with each other. You are already talking about THE verifiable credentials and not any old VCs, so you are inconsistent. Furthermore the VP is optional so may not be there to be verified. Therefore this text should read

The verifier verifies the authenticity of the presented verifiable credentials
and the verifiable presentation containing them, if present.

<li>
The <a>verifier</a> <a>verifies</a> that the <a>holder</a> possesses the
<a>verifiable credentials</a>.
A <a>verifier</a> <a>verifies</a> that the <a>holder</a> that made the
<a>verifiable presentation</a> possesses the <a>verifiable credential(s)</a>
contained therein.
</li>
<li>
The <a>verifier</a> decides whether to accept the <a>verifiable credentials</a>
for the requested action, taking into account its policy, the <a>holder</a>,
and the contents of the <a>verifiable credentials</a>.
A <a>verifier</a> decides whether to accept the <a>verifiable credentials</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly this should be The verifier for the reasons stated above. (Note you are already talking about The verifiable credentials :-)

for the requested action, taking into account its policy, the presenting
<a>holder</a>, and the contents of the <a>verifiable credentials</a>.
</li>
<li>
The <a>verifier</a> either performs the requested action or rejects the
request.
A <a>verifier</a> either performs a requested action or rejects the request
for that action.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rejected for the same reason as above. The original text was correct in using definite rather than indefinate articles.

</li>
</ol>

Expand Down