-
Notifications
You must be signed in to change notification settings - Fork 118
Use URI id for credentialStatus and refreshService #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe we may want to use URI and add an additional statement(s) that there's an expectation that machine readable information needs to be retrievable either from the URI or via some other field value in the |
The issue was discussed in a meeting on 2021-09-15
View the transcript3.1. Use URI id for credentialStatus and refreshService (pr vc-data-model#819)See github pull request #819. David Chadwick: This is a PR that uses a URI id for Manu Sporny: This is a normative breaking change. It doesn't matter if it's a subset: we are changing the normative... what's allowed.
Brent Zundel: Question for group: do we agree that this is a bug in the specification? Manu Sporny: I didn't get a change to review... I recall we limited it on purpose - but don't remember if it was these two things specifically.
Brent Zundel: That is the primary question. Is this addressing errata. Is it substantive... because we can only make substantive changes in response to errata. Kyle Den Hartog: The only time I'm aware of this being a concern is with Manu Sporny: Now... my memory is being jogged... we absolutely meant URL. So I believe probably the fix is wrong and we shouldn't merge this. Ted Thibodeau Jr.: I'm fine with having the discussion in the GitHub pages... but having a URL does not guarantee it is dereferencable any more than URI...
Brent Zundel: Reminder, the conversation minuted here will automatically go into the PR. I agree that conversation should continue there.
Brent Zundel: We'll move to the next Pull Request. |
Needs to be targeting the v1.2 branch instead of main. |
The issue was discussed in a meeting on 2021-09-29
View the transcript1.5. Use URI id for credentialStatus and refreshService (pr vc-data-model#819)See github pull request #819. Wayne Chang: One more PR review... This one by cel. Manu Sporny: yes Charles Lehner: yes Wayne Chang: Looks like there is no v1.2 branch, we'll resolve out of band. |
Merge conflicts, please fix @clehner. We're trying to get this merged down by the end of the week. |
b3bea59
to
c52a913
Compare
cleaned up the merge conflicts on this. Normative and substantive, multiple reviews, no objections, merging. |
Thanks @kdenhartog! |
There's a linked issue with the Errata label, removing the Errata label from the PR |
Fix #748. This changes the MUST requirement for credentialStatus id and
refreshService id to be URI instead of URL. The purpose of this change is to
improve consistency with the rest of the data model, where
id
s are expectedto be URIs (but not necessarily URLs). This should help implementers who want to ensure conformance with the VC Data Model without feeling compelled to check whether or not certain values are URLs, which may be a difficult determination to make without further specification by extensions. For example, there the VC Test Suite doesn't check URL-ness of refresh service ids: https://github.com/w3c/vc-test-suite/blob/593d5a5fb83f89ba60f32c0443d01fced5b4a3db/test/vc-data-model-1.0/21-refresh.js#L59 . Also, this specification doesn't seem to define URL or directly reference RFC 1738 - Uniform Resource Locators (URL), although it does have a definition for URI and identifier, and cites RFC 3986 - Uniform Resource Identifier (URI): Generic Syntax.
The other use of URL, in evidence
ids
, I have not changed in this PR, as that is a SHOULD, so I understand it would not be necessary to check for strict conformance. Maybe it is more useful to leave that part in to indicate the intended use of it?As discussed on the 2021-09-08 VCWG call, these changes may be substantive, since it changes MUSTs, but also might not be, if it is considered that checking whether it is a URL might not by programatically possible as currently specified.
Preview | Diff