Skip to content

cherry-pick commits from main to V1.1 #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Conversation

kdenhartog
Copy link
Member

@kdenhartog kdenhartog commented Sep 30, 2021

I noticed that two PRs, #808 and #786 were originally pointed at main when they should have been merged onto the V1.1 branch per our process in a transparent way. This is the first of two PRs to cherry-pick the commits from main and merge them onto V1.1 instead. The second PR will remove those PRs from the main branch as well.


Preview | Diff

chaals and others added 2 commits September 30, 2021 16:05
* Update presentation-graph.svg
* SVG coding changes
- make text into actual text
- use stylesheet
- simplify source for legibility
- Order similar to the flow, for accessibility
- Make credential-graph.svg a subsection, and note with a comment.
- Add slight background colouring to further delineate each subsection
* label the claim
As per comment from @TallTed
* differentiate graph labels
change font characteristics for graph-labels to distinguish them
(and make the stylesheet more explicitly obvious)
* Add desc (text alternative) in diagrams
This makes credentialgraph.svg and presentation-graph.svg more accessible as standalone diagrams.
* review comments
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Brent Zundel <[email protected]>
@kdenhartog
Copy link
Member Author

Going to be leaving this PR unlabeled since I don't want this to be automatically picked up by the errata page since it's more about git branch cleanup. Instead, we'll leave the original PRs properly labelled so that they are linked to in the errata page and a reader reviewing the Errata page will be properly linked back to the PR where the discussion occurred.

@kdenhartog kdenhartog merged commit e0ec8de into v1.1 Sep 30, 2021
@kdenhartog kdenhartog deleted the kdh/v1.1-cherry-picked branch September 30, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants