-
Notifications
You must be signed in to change notification settings - Fork 14
remove securing json #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove securing json section - focus on securing core data model
This will let us focus very clearly on securing the core data model section and have something very usable. This is obviously not to say we don't want to secure JSON with registered claims, but that we can do that elsewhere or revisit later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be the other way around. There is sufficient market interest in having a vanilla JSON payload in VC-JWT.
The issue was discussed in a meeting on 2023-05-24
View the transcript1.4. remove securing json (pr vc-jwt#88)See github pull request vc-jwt#88. Michael Prorock: We have a valid change request in -- for PR #88 -- but it will need discussion. Kristina Yasuda: Any comments on that? Orie Steele: Regarding removing VC-JWT media type and securing plain JSON -- I'm in favor of this PR. I'm in favor of this based on the day 3 F2F resolution and the work load for this group. Dave Longley: +1 to remove the section.
Kristina Yasuda: Any other PRs? |
This change might also necessitate some removal in A.1 and A.3, as well as A4.1. I think these sections would be confusing otherwise. |
@mprorock can you apply @paulfdietrich comment? And remove those appendix sections? |
done, thanks for the careful read @paulfdietrich |
@Sakurann we are not chartered to secure arbitrary JSON, we are chartered to secure "vc+ld+json". @iherman please confirm the charter details, if I am incorrect, we have wasted a tremendous amount of time, over objections that are unfounded. |
@OR13 our scope is sufficiently broad enough to support specifying how to secure arbitrary JSON using VC-JWT (in addition to how to secure vc+ld+json), but that isn't the same as having consensus to do so. |
From my perspective there is no consensus to define a normative mapping, or to retain optional mappings with no normative teeth... this is the same as admitting there is no consensus to secure JSON, or any other content types in this working group. @brentzundel @Sakurann please establish consensus on this topic, editors can't advance the document to horizontal review without it. |
Conflict free version is here: https://github.com/w3c/vc-jwt/pull/102/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems github lag caused this to not be updated for a while, conflcts are resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong to previously approve this. This PR removes the normative language for VCs using JWT Claims Sets and the example mapping. We should keep both.
This PR should be closed without being merged.
I do not see any charter issues. The charter does not mention media types, only VC-s in general. |
I removed the labels related to external review... I am hopeful we can clean this up eventually. |
Conflicts exist. I suggest we merge this PR before merging any others, its making it very difficult to maintain the spec, and the sections in question are not needed. |
It appears that we need you to resolve the conflicts on this PR, and then maybe @selfissued (who still has an open change request, according to the reviewers list) should re-review, so it can be merged... |
@OR13 please double check that i resolved conflicts correctly - as you noted this PR is a blocker and I really can't do any work until this is in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes normative sections of the spec related to Key Discovery and Registered Claims... those sections should be preserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct.
Chairs - @brentzundel @Sakurann can we get consensus on this so we can merge - otherwise we are blocked from further work on prepping this item for CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://datatracker.ietf.org/doc/draft-terbu-oauth-sd-jwt-vc/ has been adopted by the OAuth working group. Quoting from its introduction:
This specification defines Verifiable Credentials based on the SD-JWT format with a JWT Claim Set. It can be used when there are no selective disclosable claims, too.
Doing JWT VCs in the OAuth working group - the home of both JWTs and SD-JWTs - makes sense. Since that work will happen there, I'm now OK with this PR being merged here.
Remove securing json section - focus on securing core data model
Preview | Diff