Skip to content

Add slots or associated values as backing for all attributes #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chcunningham opened this issue Apr 19, 2021 · 1 comment
Closed

Add slots or associated values as backing for all attributes #184

chcunningham opened this issue Apr 19, 2021 · 1 comment
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior

Comments

@chcunningham
Copy link
Collaborator

chcunningham commented Apr 19, 2021

When the spec was first written, I assumed it was fine to say things like:

"Assign 0 to videoFrame.cropTop".

As well as

"Assign frameA.cropTop to frameB.cropTop"

I've learned that this isn't right. We should defined associated values or internal slots as backing for all attributes and assign/read from those instead of the attribute directly. The attribute should then be defined w/ getter steps that pull from the internal slot/value.

NOTE: This is not proposing any change to the exposed interfaces/attributes. Purely a spec wording detail.

@chcunningham chcunningham added the editorial changes to wording, grammar, etc that don't modify the intended behavior label Apr 19, 2021
chcunningham added a commit that referenced this issue Apr 23, 2021
Purely mechanical change (behavior and interface unchanged). This is an
increment step toward resolving #184.
@chcunningham
Copy link
Collaborator Author

I believe this is now complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior
Projects
None yet
Development

No branches or pull requests

1 participant