Skip to content

Add AbortError or EncodingError exception as argument for rejected flush() promises #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chcunningham opened this issue Apr 21, 2021 · 1 comment · Fixed by #268
Closed

Add AbortError or EncodingError exception as argument for rejected flush() promises #188

chcunningham opened this issue Apr 21, 2021 · 1 comment · Fixed by #268
Labels
breaking Interface changes that would break current usage (producing errors or undesired behavior).

Comments

@chcunningham
Copy link
Collaborator

Alligns with how promises are rejected in the ImageDecoder proposal (#152)

Saying why the promise was rejected seems helpful. Not strictly necessary, since they may know why via other means (e.g. EncodingError would also be fired via the error callback).
@chcunningham chcunningham added the breaking Interface changes that would break current usage (producing errors or undesired behavior). label May 12, 2021
@chcunningham
Copy link
Collaborator Author

Triage note: marking 'breaking' as this changes what a promise is rejected with. Having said that, the break is very minor (most folks will probably ignore this value).

@chcunningham chcunningham mentioned this issue May 12, 2021
Closed
chcunningham added a commit that referenced this issue Jun 4, 2021
@chcunningham
Add exceptions to pending flush() promises.
26c5165 
This unifies on behavior with ImageDecoder in providing some indication
about why the flush was aborted.

Fixes #188.
Fixes #136.
@chcunningham chcunningham mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Interface changes that would break current usage (producing errors or undesired behavior).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add exceptions to pending flush() promises. w3c/webcodecs
1 participant
@chcunningham