Remove crop* from VideoDecoderConfig #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VideoDecoderConfig's cropHeight, cropWidth, cropTop and cropLeft are all deprecated, and need to be removed. Remaining references to crop* on VideoFrame and VideoFramePlaneInit will be removed in upcoming PRs dealing with VisibleRegions.
chcunningham
requested changes
May 20, 2021
There was a problem hiding this comment.
Generally looks good.
We're missing something (not your fault): we don't actually properly use config.displayWidth|Height to set the videoFrame.displayWidth|height in the decoder output algo. To do this, we need to save the active config in a slot, similar to how we did for the encoder. @sandersdan, my read of the issue convo is we prefer config display sizing to override inband sizing if provided. Sound right?
That's correct. |
- Adds a not about enforcing reasonable upper bounds to coded{Width/Height}, and their use as hints in codec selection.
- Adds a defaults for VideoDecoderConfig display{Width/Height}
- Fixes a typo
padenot
reviewed
May 21, 2021
The "Create a VideoFrame" algorithm is referenced by both VideoDecoder and ImageDecoder, and should not live in VideoDecoder.
chcunningham
approved these changes
May 21, 2021
padenot
approved these changes
May 26, 2021
|
Editors call: @aboba LGTM |
github-actions bot
added a commit
that referenced
this pull request
May 26, 2021
SHA: 0cfee37 Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
May 26, 2021
SHA: 0cfee37 Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
May 26, 2021
SHA: 0cfee37 Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VideoDecoderConfig's cropHeight, cropWidth, cropTop and cropLeft are all deprecated, and need to be removed.
Remaining references to crop* on VideoFrame and VideoFramePlaneInit will be removed in upcoming PRs dealing with VisibleRegions.
This should address issue #94.
Preview | Diff