Skip to content

Use coded size in mp4-decode sample #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2022
Merged

Use coded size in mp4-decode sample #496

merged 1 commit into from
May 24, 2022

Conversation

sandersdan
Copy link
Contributor

Fixes #495

tguilbert-google
tguilbert-google approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@tguilbert-google tguilbert-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@sandersdan sandersdan merged commit a0ead98 into main May 24, 2022
@sandersdan sandersdan deleted the sandersdan-mp4-decode-coded-size branch May 24, 2022 17:46
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
f40958e 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
38a1809 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
fac0fe7 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
8b1031e 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
9fd1fb0 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
15aa465 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
b90e777 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
358c7a3 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
b671a18 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
76731a9 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
ca0259e 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
b590463 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
d4e3f5d 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 24, 2022
@sandersdan @github-actions
Merge pull request #496 from w3c/sandersdan-mp4-decode-coded-size
955ee5e 
SHA: a0ead98
Reason: push, by @sandersdan

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
ab57642 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
21e4c53 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
c2a219c 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
729df6c 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
892ab45 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
bf691d1 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
4fa1ef1 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
c4eef4b 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
b6b5e4c 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
ef729bb 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
feda10c 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
2b61fc3 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
ff65c46 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to tguilbert-google/webcodecs that referenced this pull request Jun 30, 2022
@sandersdan @github-actions
Merge pull request w3c#496 from w3c/sandersdan-mp4-decode-coded-size
0a144ca 
SHA: a0ead98
Reason: push, by @tguilbert-google

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tguilbert-google tguilbert-google tguilbert-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebCodecs mp4-decode demo using mp4box.js set codedWidth/codedHeight incorrectly
2 participants
@sandersdan @tguilbert-google