Skip to content

When serializing some WebCodecs objects with forStorage=true, throw DataCloneError instead of TypeError #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

When serializing some WebCodecs objects with forStorage=true, throw DataCloneError instead of TypeError #590

merged 1 commit into from
Oct 27, 2022

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented Oct 20, 2022 •
edited by pr-preview bot
Loading

This applies to EncodedVideoChunk, EncodedAudioChunk, AudioData and VideoFrame, and fixes issue #589.

Preview | Diff

@padenot
When serializing some WebCodecs objects with forStorage=true, throw D…
bc750fd 
…ataCloneError instead of TypeError

This applies to EncodedVideoChunk, EncodedAudioChunk, AudioData and
VideoFrame, and fixes issue #589.
@padenot padenot requested review from aboba and youennf October 20, 2022 07:08
@youennf
Copy link
Contributor

youennf commented Oct 20, 2022

It would be good to add corresponding wpt tests

@padenot
Copy link
Collaborator Author

padenot commented Oct 20, 2022

We have a series of tests coming (under review on our side at the moment) that check various things around postMessage of VideoFrames (cross origin, same origin, same agent cluster, different agent cluster, that kind of thing), we can probably add some about storage.

dalecurtis
dalecurtis approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@dalecurtis dalecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like that's what Chrome already fires; apologies for missing this earlier!

@aboba aboba merged commit faa91a7 into main Oct 27, 2022
@aboba aboba deleted the data-clone-error branch October 27, 2022 16:58
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
61d06fb 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
18c3981 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
7b85c83 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
5689f7a 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
dabb830 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
48eb323 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
1c1d058 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
852ada2 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
65e7ab8 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
56c443a 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
1f065d0 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
a9f25ff 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
f3ab906 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
76af075 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
a80f26c 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 27, 2022
@aboba @github-actions
Merge pull request #590 from w3c/data-clone-error
9ea8fe6 
SHA: faa91a7
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ChunMinChang ChunMinChang mentioned this pull request Nov 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboba aboba aboba approved these changes

@dalecurtis dalecurtis dalecurtis approved these changes

@youennf youennf youennf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@padenot @youennf @aboba @dalecurtis