Skip to content

Add nixxquality's fixes #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add nixxquality's fixes #618

merged 1 commit into from
Feb 2, 2023

Conversation

josephrocca
Copy link
Contributor

@w3cbot
Copy link

w3cbot commented Dec 7, 2022

tidoust marked as non substantive for IPR from ash-nazg.

@josephrocca
Copy link
Contributor Author

josephrocca commented Dec 7, 2022

Copying a recent comment from nixxquality here for context:

Don't get me wrong, my solution is definitely not proper and I wouldn't recommend it.
It's merely replacing one non-standard hack that only works in some cases with another non-standard hack that only works in some media players.
The real solution would be fixing the cue writing.

Please feel free to close if these fixes are not deemed worth it RE the above comment - I probably should have separated the two fixes, since it's really only the cue writing one that's potentially problematic.

@dalecurtis dalecurtis merged commit adf65f4 into w3c:main Feb 2, 2023
@dalecurtis
Copy link
Contributor

Don't have plans to replace with mp4box.js anytime soon so just going to land this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants