-
Notifications
You must be signed in to change notification settings - Fork 143
Enable configuration of AV1 screen content coding tools #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is it really a per frame setting? |
During a screen sharing session, the content can change so that screen content coding might no longer be advisable. For example, a slide presentation could include an embedded video, or a user could shift to sharing another tab. libaom supports applying screen content coding on a per-frame basis, so having it applied per-frame in WebCodecs may make sense. |
WebCodecs Editors decision: let's put it into VideoEncoderConfig so VideoEncoder can explicitly refuse it if it's not supported. |
PR redone to make it an encoder configuration option, as discussed in the Editor's meeting. This still allows screen content coding to be turned on/off in mid-stream by calling encoder.configure(). |
Discussed at 14 April 2023 MEDIA WG meeting: https://lists.w3.org/Archives/Public/public-media-wg/2023Apr/0007.html |
Editor's meeting: merge it! |
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 3ec4530 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Late comment but since this hasn't shipped yet... can we stop saying this is "forced" and instead say it gets enabled (i.e. Wordsmithing ;-) |
(force... is used by the AV1 spec so keeping this consistent is good) |
Fix for #646
Fix for #478
Rebase of #652