Skip to content

Fix usage of RFC2119 words in privacy and security section #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented Jun 15, 2023

This fixes #648.


Preview | Diff

@padenot padenot force-pushed the 684-remove-may-privacy branch from f653c70 to d74a047 Compare June 15, 2023 14:49
Copy link
Member

@chrisn chrisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm now wondering about this:

it SHOULD not be possible for a site to mutate a codec input or output

given the spec includes mitigations as part of the normative requirements. Also, we should probably add "This section is non-normative." to both these sections.

@padenot
Copy link
Collaborator Author

padenot commented Jun 16, 2023

So we can't add rfc2119 verbs to non-normative sections see the manual of style, so we need to make a decision here.

I think this recommendation is fair (although I'm now wondering why it mentions "output" as well), but I'm wondering what others think, @dsanders11, @youennf?

I think there's agreement that mutating memory that's been passed to as an input is dangerous (that's why there are copies for now, and other mechanisms are being considered), but do implementations prevent mutating the output of codecs (e.g. mutating the encoded bytes after encoding, or mutating the media after decoding)?

@dalecurtis
Copy link
Contributor

dalecurtis commented Jun 16, 2023

@sandersdan

In general, we're likely to defer to you and Chris on the matters of legalese :)

@chrisn
Copy link
Member

chrisn commented Jun 22, 2023

I think this recommendation is fair

Yes, I agree.

Another instance I just noticed is:

User Agents SHOULD mitigate this risk by extensively fuzzing their implementation

which could be rephrased as "We expect that user agents will mitigate this risk by" (to avoid "should" or "recommend")

@aboba aboba merged commit 203730e into main Jun 22, 2023
@aboba aboba deleted the 684-remove-may-privacy branch June 22, 2023 16:21
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 22, 2023
SHA: 203730e
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisn
Copy link
Member

chrisn commented Jun 22, 2023

Hang on, why merge this when there are unresolved comments?

@aboba
Copy link
Collaborator

aboba commented Jun 22, 2023

Opened Issue for the remaining items: #689

PR addressing them is here: #690

@chrisn
Copy link
Member

chrisn commented Jun 22, 2023

Thanks! I'll file a PR for #685 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants