Skip to content

πŸ“¦ Release @webref/[email protected] #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 17, 2022

⚠ NEVER add commits to this pull request.

πŸ€– This pull request was automatically created to facilitate human review of @webref/idl changes.

🧐 Please review the diff below and version numbers. If all looks good, merge this pull request to release the changes to npm.

πŸ“¦ Latest released @webref/idl package was v2.12.1. Merging this pull request will release v3.0.0. Make sure that the bump is the right one for the changes.

✍ If any change needs to be made before release, do not add a commit to this pull request. Changes should rather be handled in a separate pull request and pushed to the default branch. You may leave this pull request open in the meantime, or close it. The pre-release job will automatically update this pull request or create a new one once the updates have made their way to the default branch.

πŸ›ˆ The actual change introduced by this pull request is a version bump in packages/idl/package.json. You should not need to review that change to decide on whether a new release should be issued. The bumped version is not the version that will be released when this pull request is merged, but rather the version that will be released next time.

diff --ignore-trailing-space '--exclude=package.json' '--unified=3' webref/node_modules/@webref/idl/compression.idl packages/idl/compression.idl
--- webref/node_modules/@webref/idl/compression.idl
+++ packages/idl/compression.idl
@@ -3,13 +3,13 @@
 // (https://github.com/w3c/webref)
 // Source: Compression Streams (https://wicg.github.io/compression/)
 
-[Exposed=(Window,Worker)]
+[Exposed=*]
 interface CompressionStream {
   constructor(DOMString format);
 };
 CompressionStream includes GenericTransformStream;
 
-[Exposed=(Window,Worker)]
+[Exposed=*]
 interface DecompressionStream {
   constructor(DOMString format);
 };

diff --ignore-trailing-space '--exclude=package.json' '--unified=3' webref/node_modules/@webref/idl/compute-pressure.idl packages/idl/compute-pressure.idl
--- webref/node_modules/@webref/idl/compute-pressure.idl
+++ packages/idl/compute-pressure.idl
@@ -8,14 +8,14 @@
   ComputePressureObserver observer
 );
 
+enum ComputePressureTarget { "cpu" };
+
 [Exposed=Window]
 interface ComputePressureObserver {
-  constructor(
-    ComputePressureUpdateCallback callback,
-    optional ComputePressureObserverOptions options = {}
-  );
-  undefined observe();
-  undefined unobserve();
+  constructor(ComputePressureUpdateCallback callback);
+  undefined observe(ComputePressureTarget target, optional ComputePressureObserverOptions options = {});
+  undefined unobserve(ComputePressureTarget target);
+  undefined disconnect();
 };
 
 dictionary ComputePressureEntry {

diff --ignore-trailing-space '--exclude=package.json' '--unified=3' webref/node_modules/@webref/idl/local-font-access.idl packages/idl/local-font-access.idl
--- webref/node_modules/@webref/idl/local-font-access.idl
+++ packages/idl/local-font-access.idl
@@ -28,9 +28,4 @@
   readonly attribute USVString fullName;
   readonly attribute USVString family;
   readonly attribute USVString style;
-
-  // Metrics
-  readonly attribute boolean italic;
-  readonly attribute float stretch;
-  readonly attribute float weight;
 };

diff --ignore-trailing-space '--exclude=package.json' '--unified=3' webref/node_modules/@webref/idl/ua-client-hints.idl packages/idl/ua-client-hints.idl
--- webref/node_modules/@webref/idl/ua-client-hints.idl
+++ packages/idl/ua-client-hints.idl
@@ -17,6 +17,7 @@
   DOMString platform;
   DOMString platformVersion;
   DOMString uaFullVersion; // deprecated in favor of fullVersionList
+  boolean wow64;
   sequence<NavigatorUABrandVersion> fullVersionList;
 };

@github-actions github-actions bot force-pushed the release-idl-20220117184322972 branch 3 times, most recently from 1bba89a to 63255e1 Compare January 19, 2022 18:42
@dontcallmedom
Copy link
Member

This is the first case of Exposed=* coming in (following whatwg/webidl#526 w3c/webidl2.js#634) - we know of some downstream code that will need to be updated (webidlpedia, struddy); it may that idlharness (as part of WPT) also need (or needed) to be updated.

Should we major-bump this release as a result?

@dontcallmedom
Copy link
Member

confirming this needed an upgrade to idlharness - see web-platform-tests/wpt#31851

@tidoust
Copy link
Member

tidoust commented Jan 20, 2022

Then I would do a major bump to account for the change of semantics.

tidoust added a commit that referenced this pull request Jan 20, 2022
Minor version bump needed for #457 to account for the change of semantics that
the new `Exposed=*` IDL construct creates.
@github-actions github-actions bot force-pushed the release-idl-20220117184322972 branch from 63255e1 to fc6d71c Compare January 20, 2022 10:21
@github-actions github-actions bot changed the title πŸ“¦ Release @webref/[email protected] πŸ“¦ Release @webref/[email protected] Jan 20, 2022
@tidoust tidoust merged commit 4c106d9 into main Jan 20, 2022
@tidoust tidoust deleted the release-idl-20220117184322972 branch January 20, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants