Add audioLevel to RTCEncodedAudioFrameMetadata #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
approved these changes
May 8, 2025
youennf
approved these changes
May 15, 2025
| <p> | ||
| The audio level of this frame. The value is between 0..1 (linear), | ||
| where 1.0 represents 0 dBov, 0 represents silence, and 0.5 represents | ||
| approximately 6 dBSPL change in the sound pressure level from 0 dBov. |
There was a problem hiding this comment.
Maybe we could add that audioLevel is there for sending side and is based on RTP header extension for receiving.
It it also probably the audio level of this frame, not of others.
There was a problem hiding this comment.
Maybe on sending side, state that this is what would be used for the RTP header extension.
|
Editor meeting discussion: let's clarify the relationship with the RTP header extension in a follow-up (both sending and receiving side). |
|
Guido to come up with a clarification PR next week. |
github-actions bot
added a commit
that referenced
this pull request
May 15, 2025
SHA: 8c38a88 Reason: push, by youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff