Skip to content

Fix #215: make the API entry point a namespace. #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

zolkis
Copy link
Contributor

@zolkis zolkis commented Jun 18, 2020

Also, apply Web IDL namespace rules.

Signed-off-by: Zoltan Kis [email protected]

@zolkis zolkis requested review from relu91 and danielpeintner June 18, 2020 18:26
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems right, even if I liked more WOT as namespace than WebOfThings. However, I understand that WebOfThings is more evocative and less obscure. What about simply Things?

Also, this commit actually does not fix #215 because the issue was related to typescript definition file. So even after merging this we still need to fix typescript typings.

@zolkis
Copy link
Contributor Author

zolkis commented Jun 19, 2020

I thought this issue was to draw attention to namespaces because of the node-wot issue.
From the other hand, IIRC we have got that feedback to use a namespace also from elsewhere.

I am fine with the WOT name, this PR was a bit provocative with this (better readable) name.
I thought spelling it out plays better with Web IDL guidance on namespace naming, and be more clear in the same time. IMHO it makes things more clear/explicit when you import/use WebOfThings vs WOT. But no hard take on that.

@zolkis
Copy link
Contributor Author

zolkis commented Jun 19, 2020

@danielpeintner
Copy link
Contributor

It seems right, even if I liked more WOT as namespace than WebOfThings. However, I understand that WebOfThings is more evocative and less obscure. What about simply Things?

I agree with @relu91
I don't think changing "WOT" to "WebOfThings" is a good idea. It conflicts with a product too.

And in general I think this is a TypeScript issue.. but it may also relate to IDL namespaces...

@zolkis
Copy link
Contributor Author

zolkis commented Jun 19, 2020

Changed the name back to WOT.

@zolkis zolkis merged commit 2a94197 into w3c:master Jun 22, 2020
@zolkis zolkis deleted the namespace-wot branch June 22, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants