Skip to content

Fix #244: ConsumeThing constructor and consume() should do the same #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2020
Merged

Fix #244: ConsumeThing constructor and consume() should do the same #259

merged 2 commits into from
Sep 14, 2020

Conversation

zolkis
Copy link
Contributor

@zolkis zolkis commented Sep 14, 2020 •
edited by pr-preview bot
Loading

WiP:

  • moved one clause from consume() to ConsumedThing constructor
  • however, binding initialization step is problematic in constructor.

Signed-off-by: Zoltan Kis [email protected]

Preview | Diff

@zolkis zolkis merged commit 7a59934 into w3c:master Sep 14, 2020
@zolkis zolkis deleted the consume-ctor branch September 14, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpeintner danielpeintner danielpeintner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zolkis @danielpeintner