Remove eventHandler #423
Merged
Remove eventHandler #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolkis
reviewed
Aug 8, 2022
index.html
Outdated
| </li> | ||
| <li> | ||
| If |data| is `undefined`, assume that the notification |response| | ||
| will contain a `void` data payload. |
There was a problem hiding this comment.
I suggest reformulating to more exact prose, to something like
If |data| is
undefined, let |response|'s |data| beundefined
(needs to be done consistently over all occurrences of |response|
There was a problem hiding this comment.
Call of 2022-08-08
@relu91 will work (provide) an alternative to make clear what void means..
zolkis
approved these changes
Aug 8, 2022
danielpeintner
approved these changes
Aug 8, 2022
zolkis
reviewed
Sep 26, 2022
index.html
Outdated
| </li> | ||
| <li> | ||
| If |data| is `undefined`, assume that the notification |response| | ||
| will contain a `empty` data payload as specified by <a>Protocol Bindings</a>. |
There was a problem hiding this comment.
This is too generic here. From an algorithm we need to point to exact steps or algorithms from another spec.
If the referred spec doesn't have that, we need to figure that out for the HTTP protocol binding and include the steps here. Let's track that in a separate issue.
|
Scripting Call 2022-09-26 |
danielpeintner
added a commit
that referenced
this pull request
Sep 26, 2022
PR #423 introduced the emphasis for __empty__. I suggest to remove it all together. 1. emph is for LaTeX (my fault), in HTML it should be <em> 2. I quickly skimmed the current document and we use empty without emphasizing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed #408 this PR removes references to
eventHandlerfrom the API.Preview | Diff