Skip to content

IE11 Issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhildenbiddle opened this issue Feb 7, 2021 · 3 comments · Fixed by #2
Closed

IE11 Issues #1

jhildenbiddle opened this issue Feb 7, 2021 · 3 comments · Fixed by #2

Comments

@jhildenbiddle
Copy link
Contributor

jhildenbiddle commented Feb 7, 2021

ChildNode.remove() is not supported by IE11 which docsify v4.x officially supports. The use of this method is breaking https://docsify.js.org/ for IE11 users.

window.DocsifyCarbon.scriptEl.remove()

Should be:

window.DocsifyCarbon.scriptEl.parentNode.removeChild(window.DocsifyCarbon.scriptEl)

I would have created a PR, but you don't have a build in place to generate index.min.js.

Thanks!

@waruqi
Copy link
Owner

waruqi commented Feb 7, 2021

you can open a pr to modify index.js and index.min.js

@jhildenbiddle
Copy link
Contributor Author

@waruqi Yes. I am aware.

Since your repo does not include a build script or instructions on how others should build/minify, my hope was that you would make the one line change, minify as you have previously, and then publish a point release.

I am happy to add some basic instructions for minification in addition to the fix. Just let me know if you have a preferred library and settings.

@waruqi
Copy link
Owner

waruqi commented Feb 7, 2021

I use an online js compression tool, but I forgot which one I used, sorry.

You can choose a build/minify tool you recommend to generate it. As long as it can run normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants