Skip to content

use builtin WebAssembly interface instead of AST parser #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2018
Merged

use builtin WebAssembly interface instead of AST parser #4

merged 1 commit into from
Aug 24, 2018

Conversation

devsnek
Copy link
Contributor

@devsnek devsnek commented Aug 24, 2018

out of curiosity, how do you plan to interoperate with the future WASM modules being worked on by the web assembly working group? i was going to add wasm loading to node core but ended up cancelling the feature because of that (nodejs/node#18972)

Copy link
Member

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting, this means less dependencies and I 👍 it.

@sendilkumarn
Copy link
Member

@devsnek That is another story but we will have to wait for the WASM modules Might be @xtuc already a part of that Working Group.

Agree that we should change things here once when the decisions are made. ( Were they made already ? I am not sure).

And again, thanks and congrats on your First contribution 🎉

@xtuc
Copy link
Member

xtuc commented Aug 24, 2018

Yes @sendilkumarn, i'm already following the esm integration closely and I made the integration in Webpack.

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I used @webassemblyjs/* to be able to rewrite the binary on the fly (to be able to fit into the ESM for example) but since we don't use any of these features, i'm fine merge this!

Thanks.

@xtuc xtuc merged commit a74d3ac into wasm-tool:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants