fix(dev-server): pin webpack-dev-server version #7784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
approved these changes
Sep 4, 2024
jerrykingxyz
approved these changes
Sep 4, 2024
|
It would be interesting if rspack team could rewrite this part in rust too. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #7782
rspack-dev-server use some internal api of webpack-dev-server, which cause it's easily broken if webpack-dev-server do some internal refactor
so the temporary solution is to pin the webpack-dev-server version
we need redesign rspack-dev-server implemention and shouldn't rely on internal api
Checklist