Fetch: Support BYOB reading for Response.body #40281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 29, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4573009
branch
6 times, most recently
from
d72b3c3 to
1b9657e
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4573009
branch
from
1b9657e to
b573cbc
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4573009
branch
3 times, most recently
from
7ce3688 to
094f803
Compare
ReadableByteStream is a variant of ReadableStream specialized for bytes[1]. Given the performance benefits, this CL adds BYOB support for Fetch by making Response.body a byte stream to allow for reading with a bring-your-own-buffer(BYOB) reader. The corresponding spec PR for this was landed at whatwg/fetch#1593. Tests for reading from Blob with a BYOB reader were factored out, as support for that will be implemented in follow-up CLs. [1] https://streams.spec.whatwg.org/#readable-byte-stream Low-Coverage-Reason: Behavior changes are covered by WPTs (i.e. response-consume-stream.any.js). Bug: 1243329 Change-Id: I381b9f2272a7f1202fa748ae5c039ca0a998de00
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4573009
branch
from
094f803 to
977cf38
Compare
|
Close this PR because the Chromium CL does not have exportable changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadableByteStream is a variant of ReadableStream specialized for
bytes[1]. Given the performance benefits, this CL adds BYOB support
for Fetch by making Response.body a byte stream to allow for reading
with a bring-your-own-buffer(BYOB) reader.
The corresponding spec PR for this was landed at whatwg/fetch#1593.
Tests for reading from Blob with a BYOB reader were factored out, as
support for that will be implemented in follow-up CLs.
[1] https://streams.spec.whatwg.org/#readable-byte-stream
Low-Coverage-Reason: Behavior changes are covered by WPTs (i.e. response-consume-stream.any.js).
Bug: 1243329
Change-Id: I381b9f2272a7f1202fa748ae5c039ca0a998de00
Reviewed-on: https://chromium-review.googlesource.com/4573009
WPT-Export-Revision: 94b522f8145c49394398cf9d3d6aeb8d901328dc