This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix #1844 rpc call 'getGasPrice' is called even when tx.gasPrice is set to 0. #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nujabes403
changed the title
nujabes403
changed the title
frozeman
reviewed
Aug 6, 2018
| @@ -561,7 +561,7 @@ Method.prototype.buildCall = function() { | |||
| }; | |||
|
|
|||
| // Send the actual transaction | |||
| if(isSendTx && _.isObject(payload.params[0]) && !payload.params[0].gasPrice) { | |||
| if(isSendTx && _.isObject(payload.params[0]) && payload.params[0].gasPrice === undefined) { | |||
There was a problem hiding this comment.
better is typeof payload.params[0].gasPrice === 'undefined'
|
Description Type of change
Checklist:
@nivida Changed PR formatting. |
frozeman
approved these changes
Aug 7, 2018
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
…is set to 0. (web3#1845) * Fix bug: Call 'getGasPrice' rpc when tx.gasPrice is set to 0 intentionally * Compare whether the value is undefined through 'typeof' operator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrongly calling 'getGasPrice' even when tx.gasPrice is set to 0. (#1844 )