This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Web3 core types #2114
Merged
Web3 core types #2114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nivida
suggested changes
Dec 10, 2018
|
@nivida addressed all comments please look again |
|
@nivida can you merge now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created web3-core types
@nivida if you can confirm what the types are for any of the
anytypes that would be great (if they can be strongly typed).This was the main one i would like to sort..
Also due to
web3-coreusingweb3-core-methodseven thoughweb3-coreis not dependant onweb3-core-methods, makes it super hard to write any types for those. I have left them asanyfor now as we can't really do much until we sort the dependency issue out.cheers 👍