Skip to content

feat: add new package @wdio/image-comparison-core #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 70 commits into
base: ws/@wdio/image-comparison-core
Choose a base branch
from
Draft

feat: add new package @wdio/image-comparison-core #982

wants to merge 70 commits into from

Conversation

wswebcreation
Copy link
Member

@wswebcreation wswebcreation commented Jun 8, 2025 •
edited
Loading

This PR will create a new core-module which will replace the webdriver-image-comparison module with a module that can only be used by WDIO. This will reduce the complexity for the @wdio/visual-testing service

TODO:

  • Make it work with MultiRemote
  • Make it work for Mobile:
    • web
      • iOS => issue with the fullpage, the crop of the bottom is not correct
      • Android
    • native
      • iOS
      • Android
  • Desktop
  • Storybook
  • Unit tests:
    • optimise mocks for method options

@wswebcreation
feat: add new package @wdio/image-comparison-core
3a90f87 
Started
- migrating code
- optimize types
- remove executor and replace by wdio methods
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 37bb47a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wswebcreation
feat: update getMobileViewPortPosition
17f13e9 
- fix tests
@wswebcreation
chore: replaced takeBase64Screenshot implementation
788379b 
- updated tests
@wswebcreation
chore: fixed afterScreenshot
64a70fd 
- updated tests
@wswebcreation
chore: updated beforeScreenshot
656b605 
- fixed and added UT's
@wswebcreation
chore: clean saveWebScreen from methods
e7d24be 
- fix UT's
@wswebcreation
chore: update checkScreen
ea534d1
@wswebcreation
chore: fix checkWebScreen
d45788d
@wswebcreation
chore: fix saveElement and checkElement
ce2924c
@wswebcreation
chore: add full/tabbable page
465c237
@wswebcreation
chore: remove methods
b77d64a
@wswebcreation
chore: adjust the visual service to use the new core
fd08bab
@wswebcreation
chore: migrated the service to the new module
4c02e6f 
- fixed UTs and imports
@wswebcreation
chore: add browserInstance to the commands
bf53f12
@wswebcreation
chore: added the browserinstance back and fix UTs
e95aa5c
@wswebcreation
fix UT's
95dc2ae
@wswebcreation
fix tests
90dfbef
@wswebcreation
chore: cleanup methods
744ac3f
@wswebcreation
chore: remove webdriver-image-comparison
2ab6c0a
@wswebcreation
chore: multiple fixes
0f3c866 
- fix BiDi check
- fix determining iOS currentOffsets
- fix calculating remaining content for mobile fullpage screenshots
- add extra debug logging when the fullpage scroll becomes negative
- updated baselines
@wswebcreation
chore: fix UT's
e955cdc
@wswebcreation
chore: optimize types
816a4bb
@wswebcreation
test: add tests vor checkAppElement
e602d03
@wswebcreation
chore: make private package public
f90448c
@wswebcreation
test: add checkAppScreen tests
9e3fe35
@wswebcreation
tesT: add new tests
8982a13
@wswebcreation
chore: refactor mocks
90f61b3
@wswebcreation
chore: simplify checks
bb4b1be
@wswebcreation
test: add checkScreen tests
3b00a1c
@wswebcreation
test: add saveScreen tests
a4a55b6
@wswebcreation
test: add saveTabbablePage tests
161fb34
@wswebcreation
test: add saveWebElement tests
25217ae
@wswebcreation
test: add saveWebScreen tests
76af390
@wswebcreation
chore: create BEFORE_SCREENSHOT_MOCK
103e869
@wswebcreation
chore: optimize mocks
d412d9b 
- saveWebElement
- saveAppScreen
- saveAppElement
- saveWebScreen
- saveTabbablePage
- saveElement
- mocks file
@wswebcreation
test: add drawTabbableOnCanvas tests
9d22581
@wswebcreation
test: add more tests drawTabbableOnCanvas
2ec9c98
@wswebcreation
test: add more tests for drawTabbableOnCanvas
b54cf3d
@wswebcreation
test: update drawTabbableOnCanvas
9e90993 
- add comments for whats's not properly testable
@wswebcreation
chore: added todo's
c2acf1a
@wswebcreation
test: add scrollElementIntoView tests
4f1d58f 
- fix screendimentions test
@wswebcreation
test: add scrollToPosition tests
ba3af64
@wswebcreation
test: add createCompareReport tests
a5435e4
@wswebcreation
test: add processDiffPixels
a6505b6
@wswebcreation
test: add makeCroppedBase64Image tests
ffcc1ca
@wswebcreation
test: add executeImageCompare tests
120e16d
@wswebcreation
test: add makeFullPageBase64Image tests
effd60e
@wswebcreation
test: add takeResizedBase64Screenshot tests
adbcf31
@wswebcreation
fix: fix object comparison and add proper logging for takeBase64Eleme…
61fecd0 
…ntScreenshot

- add new UT's for takeBase64ElementScreenshot part 1
@wswebcreation
test: add more tests for takeBase64ElementScreenshot
6484d58
@wswebcreation
fix: fix images tests
78e9899
@wswebcreation
chore: use snapshots
629fdc8
@wswebcreation
test: add takeWebElementScreenshot tests
cfcc1f2
@wswebcreation
test: add logHiddenRemovedError
9a9a189
@wswebcreation
test: add getDesktopFullPageScreenshotsData
ef15aa9
@wswebcreation
test: add getAndroidChromeDriverFullPageScreenshotsData
1970366
@wswebcreation
test: add getMobileFullPageNativeWebScreenshotsData
36bf36f
@wswebcreation
chore: some small fixes
37bb47a
@wswebcreation wswebcreation changed the base branch from main to ws/@wdio/image-comparison-core June 24, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wswebcreation