feat(widget-meet): Render video srcObject instead of url #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzang
commented
Apr 3, 2017
| el.srcObject = srcObject; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We have to do this because React strips out all non-whitelisted props. Currently srcObject is not allowed
|
We should track this as well: facebook/react#9146 |
ianwremmel
reviewed
Apr 3, 2017
| src={src} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| Video.propTypes = { | ||
| audioMuted: PropTypes.bool, | ||
| src: PropTypes.string.isRequired | ||
| src: PropTypes.string, |
There was a problem hiding this comment.
Should we get rid of src entirely?
| @@ -75,7 +77,8 @@ export default function reducer(state = initialState, action) { | |||
| const mediaState = { | |||
| localAudioDirection: call.localAudioDirection, | |||
| localVideoDirection: call.localVideoDirection, | |||
| localMediaStreamUrl: call.localMediaStreamUrl | |||
| localMediaStreamUrl: call.localMediaStreamUrl, | |||
There was a problem hiding this comment.
Should we stop using the url fields entirely?
adamweeks
reviewed
Apr 3, 2017
| toPersonAvatar, | ||
| toPersonName | ||
| }) { | ||
| const connectedClass = remoteMediaStreamUrl && styles.callConnected; |
There was a problem hiding this comment.
Why are we still storing the remote/local media stream url if we're not using it?
ianwremmel
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
createObjectURLlosing support for media streams, we've created a work around for the react video element to support asrcObject