Use phpstan instead of scrutinizer's own checker #569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! Will merge after #566 to avoid broken builds %) |
simPod
reviewed
Nov 2, 2019
There was a problem hiding this comment.
These reports are often handy but now they're gone. Wouldn't it be better to remove problematic failure conditions rather than fully disabling scrutinizer-run?
- 'issues.severity(>= MAJOR).new.exists' # New issues of major or higher severity
- 'project.metric_change("scrutinizer.test_coverage", < 0)' # Code Coverage decreased from previous inspection
|
Also just noticed it seems to be possible to set check as not required.
|
|
Oh, sorry, this isn't finished yet--I only opened a PR because the branches don't seem to run checks... |
Absolutely; I'm trying to figure out how to generate the reports from our tools instead of Scrutnizer's black box crap. |
|
Superseded by #583 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with replacing Scrutinizer's proprietary checker with PHPStan.
This doesn't work yet--supposedly any tool that implements the
general-checkstyleformat can replace Scrutinizer's own checks, but while Scrutinizer does parse the new data, it doesn't seem to display it in its report. Please let me know if you have any ideas...