Skip to content

fix phpdoc annotation for GraphQL\Type\Definition\ObjectType::$resolveFieldFn #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mavimo
Copy link

@mavimo mavimo commented Nov 2, 2019

The field should be nullable (as per definition in constructor) but the phpDoc annotation definition do not report the nullable type.

@vladar
Copy link
Member

vladar commented Nov 3, 2019

Thanks for the PR! I would have merged it but we just merged a broader scope PR #566 which addressed this.

@vladar vladar closed this Nov 3, 2019
@mavimo mavimo deleted the fix-wrong-indication-on-nullable-type branch November 3, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants