This repository was archived by the owner on Jun 25, 2020. It is now read-only.
refactor: apply webpack defaults #51
+7,772
−98
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "presets": [ | ||
| [ | ||
| "env", | ||
| { | ||
| "useBuiltIns": true, | ||
| "targets": { | ||
| "node": "4.3" | ||
| }, | ||
| "exclude": [ | ||
| "transform-async-to-generator", | ||
| "transform-regenerator" | ||
| ] | ||
| } | ||
| ] | ||
| ], | ||
| "plugins": [ | ||
| [ | ||
| "transform-object-rest-spread", | ||
| { | ||
| "useBuiltIns": true | ||
| } | ||
| ] | ||
| ], | ||
| "env": { | ||
| "test": { | ||
| "presets": [ | ||
| "env" | ||
| ], | ||
| "plugins": [ | ||
| "transform-object-rest-spread" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # editorconfig.org | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 2 | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [.md] | ||
| insert_final_newline = false | ||
| trim_trailing_whitespace = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /node_modules | ||
| /dist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "extends": "webpack", | ||
| "rules": { | ||
| "no-template-curly-in-string": 0 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| yarn.lock -diff | ||
| * text=auto | ||
| bin/* eol=lf | ||
| package-lock.json -diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <!-- | ||
| 1. Check the version of package you are using. If it's not the newest version, update and try again (see changelog while updating!). | ||
| 2. If the issue is still there, write a minimal project showing the problem and expected output. | ||
| 3. Link to the project and mention Node version and OS in your report. | ||
| **IMPORTANT! You should use [Stack Overflow](https://stackoverflow.com/) for support related questions.** | ||
| --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <!-- | ||
| 1. [Read and sign the CLA](https://cla.js.foundation/webpack/webpack.js.org). This needs to be done only once. PRs that haven't signed it won't be accepted. | ||
| 2. Check out the [development guide](https://webpack.js.org/development/) for the API and development guidelines. | ||
| 3. Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort. | ||
| --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,18 @@ | ||
| node_modules | ||
|
|
||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| .eslintcache | ||
| /coverage | ||
| /dist | ||
| /local | ||
| /reports | ||
| /node_modules | ||
| .DS_Store | ||
| Thumbs.db | ||
| .idea | ||
| .vscode | ||
| *.sublime-project | ||
| *.sublime-workspace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| sudo: false | ||
| dist: trusty | ||
| language: node_js | ||
| branches: | ||
| only: | ||
| - master | ||
| jobs: | ||
| fast_finish: true | ||
| allow_failures: | ||
| - env: WEBPACK_VERSION=canary | ||
| include: | ||
| - &test-latest | ||
| stage: Webpack latest | ||
| node_js: 6 | ||
| env: WEBPACK_VERSION=latest JOB_PART=test | ||
| script: npm run travis:$JOB_PART | ||
| - <<: *test-latest | ||
| node_js: 4.8 | ||
| env: WEBPACK_VERSION=latest JOB_PART=test | ||
| script: npm run travis:$JOB_PART | ||
| - <<: *test-latest | ||
| node_js: 8 | ||
| env: WEBPACK_VERSION=latest JOB_PART=lint | ||
| script: npm run travis:$JOB_PART | ||
| - <<: *test-latest | ||
| node_js: 8 | ||
| env: WEBPACK_VERSION=latest JOB_PART=coverage | ||
| script: npm run travis:$JOB_PART | ||
| after_success: 'bash <(curl -s https://codecov.io/bash)' | ||
| - stage: Webpack canary | ||
| before_script: npm i --no-save git://github.com/webpack/webpack.git#master | ||
| script: npm run travis:$JOB_PART | ||
| node_js: 8 | ||
| env: WEBPACK_VERSION=canary JOB_PART=test | ||
| before_install: | ||
| - 'if [[ `npm -v` != 5* ]]; then npm i -g npm@^5.0.0; fi' | ||
| - nvm --version | ||
| - node --version | ||
| - npm --version | ||
| before_script: | ||
| - |- | ||
| if [ "$WEBPACK_VERSION" ]; then | ||
| npm i --no-save webpack@$WEBPACK_VERSION | ||
| fi | ||
| script: | ||
| - 'npm run travis:$JOB_PART' | ||
| after_success: | ||
| - 'bash <(curl -s https://codecov.io/bash)' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Change Log | ||
|
|
||
| All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. | ||
|
|
||
| x.x.x / <year>-<month>-<day> | ||
| ================== | ||
|
|
||
| * Bug fix - | ||
| * Feature - | ||
| * Chore - | ||
| * Docs - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| Copyright JS Foundation and other contributors | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| branches: | ||
| only: | ||
| - master | ||
| init: | ||
| - git config --global core.autocrlf input | ||
| environment: | ||
| matrix: | ||
| - nodejs_version: '8' | ||
| webpack_version: latest | ||
| job_part: test | ||
| - nodejs_version: '6' | ||
| webpack_version: latest | ||
| job_part: test | ||
| - nodejs_version: '4.8' | ||
| webpack_version: latest | ||
| job_part: test | ||
| build: 'off' | ||
| matrix: | ||
| fast_finish: true | ||
| install: | ||
| - ps: Install-Product node $env:nodejs_version x64 | ||
| - npm i -g npm@latest | ||
| - npm install | ||
| before_test: | ||
| - cmd: npm install webpack@%webpack_version% | ||
| test_script: | ||
| - node --version | ||
| - npm --version | ||
| - cmd: npm run appveyor:%job_part% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = require('./index').default; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| MIT License http://www.opensource.org/licenses/mit-license.php | ||
| Author Tobias Koppers @sokra | ||
| */ | ||
| import loaderUtils from 'loader-utils'; | ||
|
|
||
| export function pitch(remainingRequest) { // eslint-disable-line no-unused-vars | ||
| const options = loaderUtils.getOptions(this) || {}; | ||
|
|
||
| let chunkNameParam = ''; | ||
|
|
||
| if (options.name) { | ||
| const opts = { | ||
| context: options.context || this.options.context, | ||
| regExp: options.regExp, | ||
| }; | ||
| const chunkName = loaderUtils.interpolateName(this, options.name, opts); | ||
| chunkNameParam = `, ${JSON.stringify(chunkName)}`; | ||
| } | ||
|
|
||
| let result; | ||
| if (options.lazy) { | ||
| result = [ | ||
| 'module.exports = function(cb) {\n', | ||
| ' require.ensure([], function(require) {\n', | ||
| ' cb(require(", loaderUtils.stringifyRequest(this, `!!${remainingRequest}`), "));\n', | ||
| ` }${chunkNameParam});\n`, | ||
| '}']; | ||
| } else { | ||
| result = [ | ||
| 'var cbs = [], \n', | ||
| ' data;\n', | ||
| 'module.exports = function(cb) {\n', | ||
| ' if(cbs) cbs.push(cb);\n', | ||
| ' else cb(data);\n', | ||
| '}\n', | ||
| 'require.ensure([], function(require) {\n', | ||
| ' data = require(", loaderUtils.stringifyRequest(this, `!!${remainingRequest}`), ");\n', | ||
| ' var callbacks = cbs;\n', | ||
| ' cbs = null;\n', | ||
| ' for(var i = 0, l = callbacks.length; i < l; i++) {\n', | ||
| ' callbacks[i](data);\n', | ||
| ' }\n', | ||
| `}${chunkNameParam});`]; | ||
| } | ||
| return result.join(''); | ||
|
There was a problem hiding this comment.
|
||
| } | ||
|
|
||
| export default () => { }; | ||
|
|
||
| /* | ||
| Output format: | ||
| var cbs = [], | ||
| data; | ||
| module.exports = function(cb) { | ||
| if(cbs) cbs.push(cb); | ||
| else cb(data); | ||
| } | ||
| require.ensure([], function(require) { | ||
| data = require("xxx"); | ||
| var callbacks = cbs; | ||
| cbs = null; | ||
| for(var i = 0, l = callbacks.length; i < l; i++) { | ||
| callbacks[i](data); | ||
| } | ||
| }); | ||
| */ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { name as PROJECT_NAME } from '../package.json'; | ||
| import bundleLoader from '../src'; | ||
|
|
||
| describe(PROJECT_NAME, () => { | ||
| test('should export the loader', (done) => { | ||
| expect(bundleLoader).toBeInstanceOf(Function); | ||
| done(); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.8