Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

Absolute paths in cache. #36

Closed
gdborton opened this issue Jul 3, 2018 · 3 comments · Fixed by #49
Closed

Absolute paths in cache. #36

gdborton opened this issue Jul 3, 2018 · 3 comments · Fixed by #49

Comments

@gdborton
Copy link

gdborton commented Jul 3, 2018

Hello!

We've been continuing to tune our build performance, and are happy to see that cache-loader seems to perform slightly better than babel-loader's cache (and are definitely happy to see that it applies to other loaders as well).

We're seeing an issue with it though in that it stores absolute paths in the cache files, which means that the cache cannot be shared across our build workers. I was hoping that I could correct the paths in the cache files directly, but it seems that the cacheKey used for naming the files is also generated using absolute paths.

This means that it's totally unusable for us in CI, which is where I think the primary benefit will be seen.

Any idea if this would be possible to correct?

@alexander-akait
Copy link
Member

@gdborton feel free to do experiment with this and send PR

@gdborton gdborton mentioned this issue Jul 9, 2018
@gdborton
Copy link
Author

gdborton commented Jul 9, 2018

@evilebottnawi PR is open.

@mistic
Copy link
Collaborator

mistic commented Dec 18, 2018

@evilebottnawi we can close this after merging #49

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants