-
-
Notifications
You must be signed in to change notification settings - Fork 51
Support for cacheContext override #49
Support for cacheContext override #49
Conversation
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 17.14% 15.92% -1.22%
==========================================
Files 2 2
Lines 105 113 +8
Branches 15 17 +2
==========================================
Hits 18 18
- Misses 73 79 +6
- Partials 14 16 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
===========================================
+ Coverage 17.14% 58.11% +40.97%
===========================================
Files 2 2
Lines 105 117 +12
Branches 15 17 +2
===========================================
+ Hits 18 68 +50
+ Misses 73 42 -31
+ Partials 14 7 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can we add couple simple tests? Because we can't have here tests and it is very bad
@evilebottnawi some testes were for that specific option! |
@evilebottnawi this PR here is dependent on #50 has I've used webpack 4 to run the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
Need rebase and CI should be green |
@evilebottnawi done |
CI is green 🎉 |
This PR give the
cache-loader
users the ability to override thecacheContext
(something close to what is being done into the dll plugin) in order to generate the cache asset paths relatively to another path. This will make it possible to save the cache and re-use it in the CI for example or even ship it for other usages.This also close/replace #37 and close #36
\cc @evilebottnawi