Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

Support for cacheContext override #49

Merged

Conversation

mistic
Copy link
Collaborator

@mistic mistic commented Dec 14, 2018

This PR give the cache-loader users the ability to override the cacheContext (something close to what is being done into the dll plugin) in order to generate the cache asset paths relatively to another path. This will make it possible to save the cache and re-use it in the CI for example or even ship it for other usages.

This also close/replace #37 and close #36

\cc @evilebottnawi

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #49 into master will decrease coverage by 1.21%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   17.14%   15.92%   -1.22%     
==========================================
  Files           2        2              
  Lines         105      113       +8     
  Branches       15       17       +2     
==========================================
  Hits           18       18              
- Misses         73       79       +6     
- Partials       14       16       +2
Impacted Files Coverage Δ
src/index.js 16.07% <0%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e288092...7db52c9. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #49 into master will increase coverage by 40.97%.
The diff coverage is 45.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #49       +/-   ##
===========================================
+ Coverage   17.14%   58.11%   +40.97%     
===========================================
  Files           2        2               
  Lines         105      117       +12     
  Branches       15       17        +2     
===========================================
+ Hits           18       68       +50     
+ Misses         73       42       -31     
+ Partials       14        7        -7
Impacted Files Coverage Δ
src/index.js 58.62% <45.83%> (+41.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8225cd...99db0fe. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add couple simple tests? Because we can't have here tests and it is very bad

@mistic
Copy link
Collaborator Author

mistic commented Dec 17, 2018

@evilebottnawi some testes were for that specific option!

@mistic
Copy link
Collaborator Author

mistic commented Dec 17, 2018

@evilebottnawi this PR here is dependent on #50 has I've used webpack 4 to run the tests

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@alexander-akait
Copy link
Member

Need rebase and CI should be green

@mistic
Copy link
Collaborator Author

mistic commented Dec 18, 2018

@evilebottnawi done

This was referenced Dec 18, 2018
@mistic
Copy link
Collaborator Author

mistic commented Dec 18, 2018

CI is green 🎉

@alexander-akait alexander-akait merged commit 22d0173 into webpack-contrib:master Dec 18, 2018
@mistic mistic mentioned this pull request Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute paths in cache.
2 participants