This repository was archived by the owner on Oct 27, 2020. It is now read-only.
feat: use find-cache-dir to determinate the default directory (options.cacheDirectory)
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested review from
sokra,
michael-ciniawsky and
joshwiens
alexander-akait
force-pushed
the
feature-use-find-cache-dir
branch
from
b5938d3 to
bec9bd3
Compare
michael-ciniawsky
changed the title
find-cache-dir for determinate cache pathfind-cache-dir to determinate the default path (options.cacheDirectory)
michael-ciniawsky
approved these changes
Nov 14, 2017
michael-ciniawsky
changed the title
find-cache-dir to determinate the default path (options.cacheDirectory)find-cache-dir to determinate the default directory (options.cacheDirectory)
sokra
approved these changes
Nov 15, 2017
michael-ciniawsky
added
semver: Major
pr_action: Merge ready
status: Approved
and removed
semver: Minor
pr_action: Review
labels
|
@evilebottnawi Could you rebase please ? :) |
Closed
alexander-akait
force-pushed
the
feature-use-find-cache-dir
branch
from
bec9bd3 to
55c59b8
Compare
|
@michael-ciniawsky done 👍 |
joshwiens
approved these changes
Nov 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many good project use
find-cache-dirfor standardize the cache storage path. Also no temp cache files into root project (no need add pattern to.gitignore).