This repository was archived by the owner on Oct 27, 2020. It is now read-only.
refactor: remove cache prefix (options.cacheKey/cacheIdentifier/cacheDirectory)
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
requested review from
sokra,
alexander-akait and
joshwiens
michael-ciniawsky
changed the title
cache prefix (options.cacheIdentifier/opti… … …ons.cacheDirectory)cache prefix (options.cacheIdentifier/options.cacheDirectory)
michael-ciniawsky
force-pushed
the
refactor
branch
from
618a208 to
118400b
Compare
michael-ciniawsky
changed the title
cache prefix (options.cacheIdentifier/options.cacheDirectory)cache prefix (options.cacheKey/cacheIdentifier/cacheDirectory)
…ons.cacheDirectory`)
….cacheDirectory`)
michael-ciniawsky
force-pushed
the
refactor
branch
from
118400b to
47e6152
Compare
Closed
joshwiens
approved these changes
Nov 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREACKING ChangescacheKey=>keycacheIdentfier=>identifiercacheDirectory=>directory