-
-
Notifications
You must be signed in to change notification settings - Fork 608
Disable Autoprefixer in cssnano #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jhnns, do you think this change is fine? Apparently this is causing many many issues when using postcss. |
Current coverage is 98.34% (diff: 100%)@@ master #361 diff @@
==========================================
Files 9 9
Lines 303 303
Methods 41 41
Messages 0 0
Branches 66 66
==========================================
Hits 298 298
Misses 5 5
Partials 0 0
|
Yes, I think it's fine. I would consider this to be a bug, so this is not a major version bump. We (probably) won't break anything by adding prefixes, we will just make CSS files bigger (assuming that autoprefixer is working correctly 😉). |
And I assume that most developers were not aware of this (including me). |
nb: autoprefixer in cssnano is removal-only, so it would have not added prefixes, only removed them. 😄 |
Thanks. Very excited about this fix. Could you ping me on release, so I could tweet about this important fix for Autoprefixer users? |
I know. But when we remove the autoprefixer from cssnano, we will essentially add prefixes to minified bundles :) |
Ah yes, of course. 👍 |
Thanks for releasing it :) |
Fix #281