Skip to content

Disable Autoprefixer in cssnano #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Disable Autoprefixer in cssnano #361

merged 1 commit into from
Oct 20, 2016

Conversation

ai
Copy link
Contributor

@ai ai commented Oct 17, 2016

Fix #281

@SpaceK33z
Copy link
Contributor

@jhnns, do you think this change is fine? Apparently this is causing many many issues when using postcss.

@codecov-io
Copy link

codecov-io commented Oct 17, 2016

Current coverage is 98.34% (diff: 100%)

Merging #361 into master will not change coverage

@@             master       #361   diff @@
==========================================
  Files             9          9          
  Lines           303        303          
  Methods          41         41          
  Messages          0          0          
  Branches         66         66          
==========================================
  Hits            298        298          
  Misses            5          5          
  Partials          0          0          

Powered by Codecov. Last update 22f6621...6f65e4b

@jhnns
Copy link
Member

jhnns commented Oct 20, 2016

Yes, I think it's fine. I would consider this to be a bug, so this is not a major version bump. We (probably) won't break anything by adding prefixes, we will just make CSS files bigger (assuming that autoprefixer is working correctly 😉).

@jhnns
Copy link
Member

jhnns commented Oct 20, 2016

And I assume that most developers were not aware of this (including me).

@SpaceK33z SpaceK33z merged commit 008e6fd into webpack-contrib:master Oct 20, 2016
@ben-eb
Copy link
Contributor

ben-eb commented Oct 20, 2016

nb: autoprefixer in cssnano is removal-only, so it would have not added prefixes, only removed them. 😄

@ai
Copy link
Contributor Author

ai commented Oct 21, 2016

Thanks. Very excited about this fix. Could you ping me on release, so I could tweet about this important fix for Autoprefixer users?

@jhnns
Copy link
Member

jhnns commented Oct 21, 2016

nb: autoprefixer in cssnano is removal-only, so it would have not added prefixes, only removed them.

I know. But when we remove the autoprefixer from cssnano, we will essentially add prefixes to minified bundles :)

@ben-eb
Copy link
Contributor

ben-eb commented Oct 21, 2016

Ah yes, of course. 👍

@codeheroics
Copy link

codeheroics commented Nov 2, 2016

Thanks for the great work! Is a release containing this fix soon planned for css-loader?

Thanks for releasing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants