Skip to content

Refactor code #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 22, 2020
Merged

Refactor code #100

merged 9 commits into from
Jun 22, 2020

Conversation

cap-Bernardito
Copy link
Member

@cap-Bernardito cap-Bernardito commented Jun 15, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Refactor
Fixes #18
Fixes #19
Fixes #39
Fixes #56
Fixes #59
Fixes #85
Fixes #91

Breaking Changes

Yes

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #100 into master will increase coverage by 20.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #100       +/-   ##
===========================================
+ Coverage   66.66%   86.66%   +20.00%     
===========================================
  Files           3        4        +1     
  Lines          33       75       +42     
  Branches        8       19       +11     
===========================================
+ Hits           22       65       +43     
+ Misses          7        6        -1     
  Partials        4        4               
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (+4.76%) ⬆️
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a951fa...e3943fd. Read the comment docs.

@cap-Bernardito cap-Bernardito force-pushed the refactor-code branch 7 times, most recently from 5173c89 to 31be7c4 Compare June 17, 2020 12:04
@cap-Bernardito cap-Bernardito marked this pull request as ready for review June 20, 2020 15:01
@alexander-akait alexander-akait merged commit 99cd968 into master Jun 22, 2020
@alexander-akait alexander-akait deleted the refactor-code branch June 22, 2020 15:33
@dolan-a
Copy link

dolan-a commented Jun 22, 2020

Great work on addressing all the above issues. Do you currently have a timeline for the next release?

@alexander-akait
Copy link
Member

@pydolan Yep, ETA is tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants